Skip to content

[tool] date_to_timestamp (#130)#133

Open
Z4kM4rm3l wants to merge 1 commit into
abduznik:mainfrom
Z4kM4rm3l:Z4kM4rm3l-patch-1
Open

[tool] date_to_timestamp (#130)#133
Z4kM4rm3l wants to merge 1 commit into
abduznik:mainfrom
Z4kM4rm3l:Z4kM4rm3l-patch-1

Conversation

@Z4kM4rm3l

@Z4kM4rm3l Z4kM4rm3l commented Jul 6, 2026

Copy link
Copy Markdown
  • File is in tools/ directory
  • File has header comments (# tool, # description, # author, # example)
  • File has a run() function that returns a string
  • Uses stdlib only (no external dependencies)
  • Tested locally with python bitbox.py <tool_name> <args>

Closes #130

@abduznik

Copy link
Copy Markdown
Owner

Hey! Thanks for the contribution. A couple things before merging:

  1. Missing required header comments -- every tool needs these at the top:

    • tool: date_to_timestamp

    • description: Converts a date string (YYYY-MM-DD) to a Unix timestamp

    • author: @Z4kM4rm3l

    • example: date_to_timestamp "2024-06-30" -> "1719705600"

  2. The run function signature should use *args to match the project convention, e.g.:
    def run(*args) -> str:
    date_str = args[0]

Once these are fixed, good to go!

@abduznik

Copy link
Copy Markdown
Owner

Hey! Just a reminder - the following still need to be fixed:

  1. Add header comments at the top of the file:
    `python

tool: date_to_timestamp

description: Converts a date string (YYYY-MM-DD) to a Unix timestamp

author: @Z4kM4rm3l

example: date_to_timestamp "2024-06-30" -> "1719705600"

`

  1. Fix run() signature to use *args:
    python def run(*args) -> str: date_str = args[0]

  2. Fix title to: [tool] date_to_timestamp (remove the ([tool] date_to_timestamp #130))

Once fixed, we can merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[tool] date_to_timestamp

2 participants