feat: add 5 new tools (decimal_to_hex, hex_to_decimal, gcd, factorial, octal_to_decimal)#201
Open
chfr19820610-cell wants to merge 1 commit into
Open
feat: add 5 new tools (decimal_to_hex, hex_to_decimal, gcd, factorial, octal_to_decimal)#201chfr19820610-cell wants to merge 1 commit into
chfr19820610-cell wants to merge 1 commit into
Conversation
…, octal_to_decimal) Closes abduznik#193, Closes abduznik#194, Closes abduznik#195, Closes abduznik#196, Closes abduznik#197, Closes abduznik#198
Owner
|
Hey! Thanks for the contribution. Before merging, please fix the PR title format: Change: eat: add 5 new tools (decimal_to_hex, hex_to_decimal, gcd, factorial, octal_to_decimal) Also, please note that some of these tools may already have open PRs or issues. Please check before submitting multiple tools in one PR. Once fixed, we can review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds 5 new mathematical/conversion tools to bitbox:
Each tool follows the existing pattern: single file in
tools/, header comment with metadata, and arun(*args) -> strfunction.Closes #193, Closes #194, Closes #195, Closes #196, Closes #197, Closes #198
If you have other issues that need fixing or features you'd like added, I'm available for more open source work. Tips appreciated:
1JDmYgWRJipA5ZHDmoVPfpfW8n3Gtbb92c