Keep player input in context when game time is frozen - #675
Closed
RANGROO wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When Skyrim's timescale is set to 0,
gametsstops advancing while NPCprechatandchatrows retain their synthetic +1/+2 values.buildHistoricContext()therefore keeps ranking NPC rows above newer player input until the bounded history window excludes the player entirely.Discord source: Open Discord thread
Change
rowid, which represents server insertion order.Validation
php -l lib/data_functions.php: passed.git diff --check: passed.rowid DESCselected the latest player input first.HistoricContextTest.php: blocked by a pre-existingsql::escapeLiteral()error; the same failure reproduces unchanged on currentorigin/unstable.Coordination and limits
buildHistoricContext()for listener filtering, but does not change history ordering or cover frozen timescale behavior.