Harden Oghma retrieval and knowledge classes - #698
Closed
RANGROO wants to merge 13 commits into
Closed
Conversation
Collaborator
Author
|
Superseded by consolidated draft #701, which contains this work plus the completed Oghma catalog, retrieval, knowledge-class, biography, parity, and UI changes. Please review the combined draft there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rift reachbasic-class assignments to distinctriftandreachclassescommonand move 53 reviewed deep-lore subjects toesotericretrieval_phrasesas the only non-topic/alias metadata allowed to identify an article by itselfknowallas an explicit advanced overrideThis consolidates the Oghma work currently split across drafts #693, #695, and #697; those PRs remain open for manual review.
Validation
php unittests/oghma_parity_harness.php --iterations=500: 63 contract cases, 0 failures; p50 0.511 ms, p95 1.215 ms, p99 1.332 ms (25 ms p95 budget)rift reach; 45 correctedrift+reach; 3 safe retrieval phrasesNight Mother->dark_brotherhood,Cloud District->dragonsreach, andColored Rooms->meridiaIt is hostile when provoked.,This is a hidden location., andTell me about the adjacent place.git diff --checkpassedLimits
PGPASSWORD=...command; the database suites were run successfully inside the configured WSL environment