fix nullability customizer #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThoSap
reviewed
Jan 16, 2026
Contributor
ThoSap
left a comment
ThoSap
left a comment
There was a problem hiding this comment.
Overall LGTM 👍🏼
Let's only clarify these things first.
Comment on lines
+18
to
+51
| public static class BaseClass { | ||
| @org.springframework.lang.Nullable | ||
| private String baseField; | ||
|
|
||
| public String getBaseField() { | ||
| return baseField; | ||
| } | ||
| } | ||
|
|
||
| public static class SubClass extends BaseClass { | ||
| private String subField; | ||
|
|
||
| public String getSubField() { | ||
| return subField; | ||
| } | ||
| } | ||
|
|
||
| public static class MethodAnnotated { | ||
| private String annotatedGetter; | ||
|
|
||
| @jakarta.annotation.Nullable | ||
| public String getAnnotatedGetter() { | ||
| return annotatedGetter; | ||
| } | ||
| } | ||
|
|
||
| public static class DirectMethodAnnotated { | ||
| private String directMethod; | ||
|
|
||
| @org.jspecify.annotations.Nullable | ||
| public String directMethod() { | ||
| return directMethod; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Here you have a mix of different @Nullable annotations.
|
|
||
| var schema = new Schema<Object>(); | ||
| // Simulating the concatenated FQN pattern described in the issue | ||
| var concatenatedFqn = SubClass.class.getName() + "Com.finstral.something"; |
Contributor
There was a problem hiding this comment.
Like you have done it in PR commit https://github.com/aboutbits/spring-boot-toolbox/pull/47/changes#diff-ad71dc1ec29d6eb4c590a1e3e61049b7de72b369f976eabf6485d7eef1c210c6R121
Suggested change
| var concatenatedFqn = SubClass.class.getName() + "Com.finstral.something"; | |
| var concatenatedFqn = SubClass.class.getName() + "It.aboutbits.something"; |
| components.addSchemas(SubClass.class.getName(), subClassSchema); | ||
| openApi.setComponents(components); | ||
|
|
||
| assertDoesNotThrow(() -> customizer.customise(openApi)); |
Contributor
There was a problem hiding this comment.
Don't we usually use AssertJ
assertThatCode(() -> call()).doesNotThrowAnyException();
instead of this JUnit one?
Same also for the ones below and assertTrue.
.../aboutbits/springboot/toolbox/swagger/customization/default_not_null/NullableCustomizer.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport to support jspecify annotation. will be release
1.7.1