Add installation script by chetanya-shrimali · Pull Request #107 · aboutcode-org/scancode-server

chetanya-shrimali · 2017-12-01T07:50:58Z

run using source ./installation.sh
It will do following things:

Set up the virtual-env scancode-server
Activate it
Install the requirements

Signed-off-by: chetanya-shrimali chetanyashrimalie5@gmail.com

chetanya-shrimali · 2017-12-01T07:53:02Z

regarding #106
Plz review @singh1114 @pombredanne

pombredanne

Thanks!
This might better named install or configure. I would much prefer using the scancode-toolkit config style here too

pombredanne · 2017-12-01T11:04:27Z

@@ -0,0 +1,5 @@
+#!/bin/bash
+virtualenv -q -p /usr/bin/python3.5 scancode-server


We are not using Python 3 for this project, but only Python 2.7 for as long as ScanCode proper is nt ported to Python 3
Also, what are -q and -p options? long form are better
Also this is not portable on Windows, is it?
I would much prefer that we adopt the configure script from scancode https://github.com/nexB/scancode-toolkit/blob/f8132b344ba3a700907c41038e3d663002bbac63/configure ... Can you look into this?

yaa, I'll see it and make required changes!!

sorry about -q and -p part, -q is for quiet and -p is an option to decide the python interpreter to create virtual env which requires python root directory as an argument.

Just use the long form in the script please.

Done that!!

pombredanne · 2017-12-01T11:04:51Z

+virtualenv -q -p /usr/bin/python3.5 scancode-server
+source scancode-server/bin/activate
+pip install -r requirements.txt
+echo "source scancode-server/bin/activate"


Why this echo? what does it bring?

that was a mistake. I'll remove it!! 😉

chetanya-shrimali · 2017-12-01T17:02:44Z

It can also be written as mentioned above.
Actually it is able to execute using git bash on windows but what it will do is install the requirements only. We i will have to add if-else condition and define methods for windows.
I can proceed to it if you are ok with it.
@pombredanne plz review!!

pombredanne · 2017-12-01T17:10:40Z

The point is not it executes, but that it pass the tests on Python3. If you can install and pass the tests of https://github.com/nexB/scancode-toolkit on Python3 that would be news to me.

chetanya-shrimali · 2017-12-01T18:02:04Z

@pombredanne That was the problem we discussed earlier regarding issue #100 in pr #105. And finalized that we have to consider that the user has already installed scancode-toolkit .
If we keep in mind that, then there is no further need install scancode-toolkit requirement and it will pass.
Plz correct me if i got your point the wrong way 😉

pombredanne · 2017-12-01T18:26:28Z

scancode-toolkit DOES NOT RUN on Python3, therefore scancode-server that depends on scancode-toolkit CANNOT RUN on Python3, simple.

chetanya-shrimali · 2017-12-01T19:03:12Z

@pombredanne Pardon, but i changed it to Python 2.7 😓

chetanya-shrimali · 2017-12-02T15:18:57Z

@pombredanne plz review!

pombredanne · 2017-12-02T15:47:56Z

@@ -0,0 +1,4 @@
+#!/bin/bash
+virtualenv --quiet --python=/usr/bin/python2.7 scancode-server


Where do you get virtualenv from?
Could you try to see how the scancode-toolkit configure script works and use this instead?

Okk!! @pombredanne i will see to how that works! but plz let me know the problem this code. Like it does what we want it to.

This script is fine. But I would rather have a proper ./configure, scancode-toolkit style

ok!! will work on that!

chetanya-shrimali · 2018-01-01T18:26:27Z

@pombredanne The error is at line 11 of etc/conf/dev/base.txt. Error message is no module named encodings. Which comes when running install.sh.

pombredanne · 2018-01-04T11:38:40Z

Thanks. I think you have copied too much from scancode etc/ ..... take only what is strictly needed. Not everything.
Also how come there are 17K+ file changed? that does not sound right?

What is media/AnonymousUser ? Why did you commit bin, lib, include and all your local virtual env things? This should never be commited and part of the gitignore (see the gitignore in scancode-toolkit)

pombredanne · 2018-01-19T08:30:36Z

Thanks!. what is the etc/configure2.py file in the commits?

pombredanne · 2018-01-19T08:30:50Z

And what are the changes you made to the original script?

chetanya-shrimali · 2018-01-19T08:45:36Z

This is not the final commit 😅

chetanya-shrimali · 2018-01-20T17:53:28Z

@pombredanne plz review. I will document it after we reach on a common solution. Thanks!

pombredanne · 2018-01-25T13:37:29Z

Thanks!
Your commit message needs to match our style. It is missing a signed-off-by and the subject should use the imperative style eg

Add installation script #106

Signed-off-by: name <email>

yash-nisar · 2018-01-25T13:38:26Z

+python2.7 "$CONFIGURE_ROOT_DIR/etc/ConfigureScript.py"
+if [ -f "$CONFIGURE_ROOT_DIR/.scancode-server/bin/activate" ]; then
+    source $CONFIGURE_ROOT_DIR/.scancode-server/bin/activate
+fi


It would be great if you could insert a newline.

yash-nisar · 2018-01-25T13:40:24Z

+
+
+def create_venv():
+    venv_dir = os.path.join(req_path, ".scancode-server")


Can we be consistent with the quotations ? Either "(double quotes) everywhere or '(single quotes) everywhere ?

we use single quote everywhere unless this is a doc string (or if the string contains single quotes)

yash-nisar · 2018-01-25T13:46:14Z

@@ -0,0 +1,29 @@
+import subprocess
+import os
+import virtualenv


Maybe we could have alphabetically sorted imports and according to the python style guide ?

Signed-off-by: Chetanya <chetanyashrimalie5@gmail.com>

chetanya-shrimali · 2018-01-27T11:30:11Z

@pombredanne i have added wincertstore in third-party dir than why does it show error?

chetanya-shrimali · 2018-02-12T13:48:19Z

@pombredanne Its been a while since the pr was opened. @singh1114 plz review.

pombredanne suggested changes Dec 1, 2017

View reviewed changes

pombredanne changed the title ~~added installation script~~ Add installation script Dec 1, 2017

pombredanne reviewed Dec 2, 2017

View reviewed changes

configured installation script

a5e6828

chetanya-shrimali force-pushed the chetanya_develop branch from 9322b9d to a5e6828 Compare January 20, 2018 17:52

yash-nisar reviewed Jan 25, 2018

View reviewed changes

chetanya-shrimali added 2 commits January 27, 2018 16:37

Add installation script

c42dc91

Signed-off-by: Chetanya <chetanyashrimalie5@gmail.com>

configured third-party dirs

0963aac

Signed-off-by: Chetanya <chetanyashrimalie5@gmail.com>

		@@ -0,0 +1,5 @@
		#!/bin/bash
		virtualenv -q -p /usr/bin/python3.5 scancode-server

		@@ -0,0 +1,4 @@
		#!/bin/bash
		virtualenv --quiet --python=/usr/bin/python2.7 scancode-server



		def create_venv():
		venv_dir = os.path.join(req_path, ".scancode-server")

Conversation

chetanya-shrimali commented Dec 1, 2017

Uh oh!

chetanya-shrimali commented Dec 1, 2017

Uh oh!

pombredanne left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chetanya-shrimali Dec 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chetanya-shrimali commented Dec 1, 2017

Uh oh!

pombredanne commented Dec 1, 2017

Uh oh!

chetanya-shrimali commented Dec 1, 2017

Uh oh!

pombredanne commented Dec 1, 2017

Uh oh!

chetanya-shrimali commented Dec 1, 2017

Uh oh!

chetanya-shrimali commented Dec 2, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chetanya-shrimali commented Jan 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pombredanne commented Jan 4, 2018

Uh oh!

pombredanne commented Jan 19, 2018

Uh oh!

pombredanne commented Jan 19, 2018

Uh oh!

chetanya-shrimali commented Jan 19, 2018

Uh oh!

chetanya-shrimali commented Jan 20, 2018

Uh oh!

pombredanne commented Jan 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chetanya-shrimali commented Jan 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chetanya-shrimali commented Feb 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

chetanya-shrimali Dec 1, 2017 •

edited

Loading

chetanya-shrimali commented Jan 1, 2018 •

edited

Loading

pombredanne commented Jan 25, 2018 •

edited

Loading

chetanya-shrimali commented Jan 27, 2018 •

edited

Loading

chetanya-shrimali commented Feb 12, 2018 •

edited

Loading