Skip to content

Updated version of gms module (includes #40 and #47) - #50

Open
bjvrielink wants to merge 9 commits into
abrader:masterfrom
bjvrielink:fixup
Open

bjvrielink wants to merge 9 commits into
abrader:masterfrom
bjvrielink:fixup

Conversation

@bjvrielink

@bjvrielink bjvrielink commented Apr 10, 2019

Copy link
Copy Markdown

PS. Please consider migrating this module to VoxPupuli (#46)...

bjvrielink and others added 7 commits April 10, 2019 09:52
replace / by %2F in project stored on sub-sub-group
- Set default Puppet version to 5.5.0
- Updated dependencies in metadata.json to more modern versions

Note: not switching to Puppet6 yet. It probably will work, but I'm not
testing too much with Puppet6 myself.
In Travis, don't test old Puppet with new Ruby versions.
- Deleted some non-supported combinations of Puppet and Ruby from Travis Matrix
- Added some form of matrix for Gitlab CI
- Gitlab CI fixes for old Puppet versions
@bjvrielink bjvrielink changed the title Updated version of gms module (includes #40 and #44) Updated version of gms module (includes #40 and #47) Apr 10, 2019
@jdub55

jdub55 commented Apr 10, 2019

Copy link
Copy Markdown

+1 to moving this to the community. This is a very helpful module and I think it's important to have reliable way to make future updates and merges.

@bjvrielink

Copy link
Copy Markdown
Author

@abrader Is there anything we can help you with getting a new version of this module published on the Puppet forge?

@benh57

benh57 commented Aug 1, 2019

Copy link
Copy Markdown

Any chance of getting this merged?

@abrader

abrader commented Feb 21, 2020

Copy link
Copy Markdown
Owner

My apologies on the delay of this reply. If this is still of interest to you, please let me know.

@jdub55

jdub55 commented Feb 21, 2020

Copy link
Copy Markdown

Based on my knowledge and issues encountered in the past, this module needs to be API version aware so it can be used with newer versions of the GitLab API...

@bjvrielink

Copy link
Copy Markdown
Author

I'm stiil using this module in combination with Gitlab today. I've upgraded to just about every Gitlab release that came out while this PR was open, and do not recall any issues. At the moment I only use the git_deploy_key type, but have also used git_webhook in the past.

The only thing I'd like to add to my PR right now is to increase the dependencies on Puppet version and stdlib version. The latter one also means dropping support for Puppet < 5.5. Any thoughts on that?

@bschonec

bschonec commented Apr 8, 2022

Copy link
Copy Markdown

I can confirm that this fix works for RHEL7 and RHEL8 on Puppet Server 7.6.0 and newer. Can we please get a merge?

@bjvrielink

Copy link
Copy Markdown
Author

@bschonec it looks like @abrader isn't really active on Github anymore? I don't know if anyone else has the rights to do merges on this repository.

Alternatively, someone should fork this module and push that to the Puppet Forge. I do still use this module, but am not involved enough with it to be the best candidate for such a fork right now. Maybe @voxpupuli can help?

@bschonec

Copy link
Copy Markdown

I sent an email to abraders' address but he has not replied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants