Skip to content

fix: preserve lossless lock and transcript identities - #135

Merged
abruption merged 2 commits into
mainfrom
fix/126-lossless-file-identity
Oct 14, 2026
Merged

abruption merged 2 commits into
mainfrom
fix/126-lossless-file-identity

Conversation

@abruption

@abruption abruption commented Oct 13, 2026 •

Copy link
Copy Markdown
Owner

Problem and change

Device and inode numbers above 2^53 can be rounded before a numeric Stats value is converted to a string, allowing distinct identities to compare equal. This prerequisite for #126 collects lock, transcript and final pre-signal transcript snapshots with BigIntStats. It preserves lossless decimal identity strings and JSON v1 shape, rejects unrepresentable numeric fields, and retains fractional modifiedMs without claiming nanosecond-exact comparison.

Validation

  • Local npm ci/check/lint, 233 tests and package smoke passed. Five regressions cover large identities, unsafe legacy numeric inputs, real files and fail-closed metadata errors.
  • CI: all 33 checks pass at ee47be8. Hosted Code and Security reviews completed for that commit without inline findings.
  • Independent source review: claude-opus-5-5 response model confirmed; isolated Codex CLI 0.162.1 default model unconfirmed. Both reviewed the same frozen input (SHA256 38751846ef1c8755e929285d37ee5580de489a440bacd9d4a2ed692a82ffd4f4) and found no blocker in this prerequisite. Real files with >2^53 inode values were not exercised; large-value coverage uses supplied stat fixtures.

Refs #126. This does not change holder-attribution policy or close its safety gates. PR #137 is stacked on this prerequisite. No merge or publication is part of this work.

@abruption abruption added this to the v0.4.6 milestone Oct 13, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T11:00:30.823094Z ee47be8 PR opened
🔒 Security Review ✅ Completed 2026-10-13T11:02:41.476214Z ee47be8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@abruption
abruption merged commit 95ea586 into main Oct 14, 2026
33 checks passed
@abruption
abruption deleted the fix/126-lossless-file-identity branch October 14, 2026 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant