Repository navigation
test: validate Windows file and process identity fixtures - #155
Merged
Merged
Conversation
abruption
marked this pull request as ready for review
October 18, 2026 03:50
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ebe4948a12
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
abruption
marked this pull request as draft
October 18, 2026 03:57
abruption
marked this pull request as ready for review
October 18, 2026 03:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a synthetic Windows identity lab for W1–W3, with a closed case manifest and independent classification of file identity, ownership/security and process instances. Missing, contradictory or changed observations remain unknown/refused; every record keeps
safeToUnlock: false.The lab uses no-follow handles and 128-bit file IDs, records SID classes rather than raw account SIDs, binds PID/FILETIME evidence to held or fresh-open handles per case, and verifies all registered cleanup handles before deletion. Fault cases preserve partial evidence and unconfirmed children. PID reuse that is not observed is partial coverage (classifier exit 4), not verified coverage.
Add separate hosted CI gates for mock tests, PowerShell 5.1 parsing/C# compilation, NTFS synthetic observations, and five fault modes. Raw lab output stays private; the workflow prints classification summaries and explicitly handles exit 4.
Refs #146, #147, #148. Milestone: v0.4.7.
Validation
npm ci, check, lint, test (263 pass / 3 Linux skips), and package smoke passed.claude-opus-5-5; Codex CLI 0.163.0 isolated default, actual model not separately reported. Both completed with the same frozen input SHA-25680c5d81e124061b7fd1bfff6a43ccdddac2c32ee7e36a43ad73a991c36de3e05.Limits
Research-only files are excluded from the npm artifact. Production behavior, supported platforms and unlock policy are unchanged. ReFS, Medium/High pairing, another user's files and native Codex remain unverified. Cleanup counts represent accepted delete dispositions; another handle can delay physical removal. No host policy, existing ACL, account or volume is changed. No merge or release is requested.