Repository navigation
test: add fail-closed Windows observer research gates - #158
Merged
Merged
Conversation
abruption
marked this pull request as ready for review
October 18, 2026 07:44
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b28328a9f6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
abruption
marked this pull request as draft
October 18, 2026 08:08
abruption
marked this pull request as ready for review
October 18, 2026 08:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Refs #151 and #152 (v0.4.7); does not close either evidence gate.
Research-only observer groundwork, an offline evidence evaluator, counterexample tests and a Windows static CI gate. The production CLI, dependencies, package allowlist, JSON v1, release metadata and operations are unchanged. Experimental files are not shipped in the npm artifact.
All observer modes (
preflight,observe,fixture-meta) are now hard-refused at the first setup statement, before path lookups, compilation or observation. No bypass or Windows support is added.safeToUnlockremains false. W7 cannot pass while coordination range is unmeasured; fixture pairing remains unbound/unknown.Latest review fixes — bf1d001
Addresses all eight findings from Code Review on b28328a. This is an implementation/verification report, not a claim that the reviewer has approved the new head.
elevationType1/2/3. Missing/invalid queries are unknown. W6 compares measured elevation values; self tokens bind to file/preflight metadata and target elevation stays stable across samples/after. Medium/High labels never imply Full/Limited types.host.volumerequires NTFS; ReFS/other/unknown filesystems cannot satisfy W7's environment evidence.unknown/deferred: guarded_handle_binding_not_implementeduntil a common synchronous guard and bound-handle design exists. It does not pretend the range-only guard covers them. Static tests detect call reinsertion.Abortbefore dormant binary hashing, disposable-home creation or version execution. No host policy is changed.Earlier follow-ups remain intact: conservative tilde/8.3 rejection; case-insensitive disposable matching; exact
Refuse/Stop-Unknowntermination contracts; content-free internal exception unknown/2; C# documentation corrections; and backslash-before-pipe Markdown escaping. At b28328a CodeQL reported no new alerts and alert #5 fixed. No alert was suppressed or manually dismissed.Validation of this revision
npm ci,npm run check,npm run lint: passed.npm test: 266 tests, 263 pass / 3 Linux-only skips / 0 failures on macOS arm64, Node 24.16.0.npm run smoke:packageandgit diff --check: passed.check.ps1:738d4fdd8278602f2e32faa35b6d501264a8c300c27a715b501c87acae4d3360observer.ps1:85a84194bef9b781a8ff3b059a87616bd0e3e46d6ae8e6b3c5eb4e4a3d477c28WinObserver.cs:9b44dc7403368857fd7c55cdf4a596310b7b501c1343755f3adc08758f3eb83c3d642797f734d144fdaf559ed4e2806a119b009cae6a26198f531c27c6eebaedIndependent review history and limits
Claude Code 2.1.302 authored the E3 handoff with self-reported
claude-opus-5-5(authoring response model not independently verified). Codex inspected and integrated it.The original E3 dual-CLI review used the same frozen bundle (SHA-256
d735c732459732f37b887fd0aabd85f28cf57bfd9aff0cf16815a204cfadf05e). Codex CLI 0.163.0 returned a substantive source review, isolated default model not separately reported. Claude Code 2.1.302 requested/reportedclaude-opus-5-5but explicitly reported a safety-classifier interruption and supplied no substantive review. Its exit 0 was not counted as review success; the failure remains recorded.The user then explicitly requested
claude-opus-5as the single reviewer of c728e82. Tools-disabled non-interactive review used a frozen 11-file bundle (SHA-256896e418102979f146d57d4fccee4cd03f61d69fa2c3aa24dc0f60df205e99743), with no credentials or other reviewer results. The first call was stopped after 10 minutes without output. After the user's explicit 30-minute wait instruction, a second identical-input/model call returned in about 15 minutes, exit 0,subtype=success,is_error=false, response model metadataclaude-opus-5. That metadata is not independent proof of provider routing. No fallback model or split input was used.That CLI review covers c728e82, not subsequent fixes. GitHub Code/Security reviews then covered b28328a. Codex verified the latest fixes with source inspection, regression tests and the exact Windows static run above. No independent-model approval of bf1d001 is claimed. The PR is ready for review; normal current-head review and human approval remain required. No separate reviewer mention was posted.
Remaining no-go conditions
No merge, release, tag, package publication or operational setting change is performed.