Repository navigation
feat(wake): bound chained wakes and per-target activation - #288
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
3 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related #238. Implement cooperative wake-chain cost controls without changing queue-only sends or the native wake version/approval boundary.
--wake-max-depth/SESSION_PEER_WAKE_MAX_DEPTHmay lower or raise it (0 disables wakes).wakeProvenanceresult.Type
Verification
Prior runtime-candidate verification (before the test/docs-only
c009972follow-up): Python 3.13.7 on macOS arm64, isolated SQLite/locks and process stand-ins:f5502a0refuses foreign-owned, group/world-readable, multiply-linked or non-regular local rate files and unsafe/symlink state directories before queueing; no automatic permission repair. Real isolated unsafe-file/directory fixtures pass.6b9826e3aa83b1a5947db50f4332cb9c65f1b340:codex-rs/protocol/src/shell_environment.rs,codex-rs/rmcp-client/src/utils.rs; current official configuration/MCP documentation was also checked. This does not expand native wake support to newer versions.Actual native environment follow-up (
c009972a39cc435dad434ab3ba3d5a53e90fdb52)command/exec, and four real stdio MCP startup cases viamcpServerStatus/list(default whitelist vs explicitenv_vars, including inherit=none).rust-v0.154.0peels to source6b9826e3aa83b1a5947db50f4332cb9c65f1b340. Archive SHA-256:344310a0a591c1b192e04feff304321a69907c9498baaac331ca7e16ebcef9d7; extracted native binary SHA-256:4f85982624b3898c8991cb80c0981b2aa71070e3537046c9a95950318a95afcc.-X dev -W error::ResourceWarning. Existing wake tests 27 PASS, docs 32 PASS, generator and diff checks PASS. Earlier full-suite results above predate this test/docs-only delta; they are not a new full-suite run of this head.SESSION_PEER_CODEX154_ENV_BINARYproduces 2 explicit skips, not native evidence. Explicit selection of a wrong binary hard-fails its pinned hash check before execution; tested with a benign wrong executable.Boundaries / remaining gates
Checklist