Repository navigation
test(codex): document first-input receipt by TUI topology - #308
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4fdc92139c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please re-review exact current head dc80705. All three original findings have been source-checked, regression-tested and resolved with per-thread explanations. Current-head CI is green; root just reran 7 offline probe tests, 61 documentation tests, generator --check and diff checks successfully. This request does not authorize live native/model tests or operational changes. Historical receipt evidence and remaining production/platform limits are unchanged. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dc807057db
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please re-review latest head 5c80632. Both new findings on dc80705 are addressed and resolved with source/test evidence. Shared RPC error validation requires integer code plus string message; queue mode requires explicit non-ephemeral metadata before database access or submission. Final offline probe tests10/docs61/generator/diff PASS; independent Opus5.5/Codex CLI review provenance and limits are in the PR body. No live native/model test or operations change is requested. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c80632b28
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please re-review exact latest head ec924de. Both findings on 5c80632 are addressed: validate the full queued submission and exact request echo before acceptance; require an explicitly complete empty first queue page immediately before the one add. The report preserves TOCTOU/no-other-producer and queued-body privacy limitations. Probe15/docs61/generator/diff pass; independent Opus5.5/Codex CLI review metadata is in the PR. No live native/model input or operations changes are authorized by this review request. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ec924debf5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please review exact latest head 97f7df7. P1 is addressed by removing local account-home SQL authority, not by guessing server startup env. Server-visible metadata/turn snapshots gate the only add; unavailable history is safely refused. Both modes explicitly opt into possible server history DB initialization/migration. The pinned source can reject turns/list before materialization, so original unsaved-first-input availability is NOT claimed; #306 remains open. Final26 offline tests/docs61/generator/diff pass and exact-head independent Opus5.5/Codex CLI provenance is in the PR. Do not run live native/model sessions or change operations. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex security review |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Summary
Current harness limitation (P1 correction): the current probe no longer uses account-home SQLite rows as freshness authority. It requires server-visible empty-turn snapshots and fails closed when history is unavailable. Native 0.162.1 can reject this lookup before the first user message, so the revised harness may not reproduce the original unsaved-first-input positive. Both modes require explicit
--allow-server-history-db-initbecause history lookup can initialize/migrate a server DB. This remains a research/report PR, not implemented general first-input support; #306 stays open. Older review sections below describe earlier revisions; the final storage-authority section records the current behavior.Refs #306; keep the investigation open for product acceptance work.
Record isolated first-input experiments without changing the public runtime:
codex queuerefused withno rollout found; TUI remained blank--remoteflag or initial prompt; one loaded idle thread, zero matching stored rowsACK CODEX-SHARED-EMPTY-306-8C2FThe third experiment started a foreground server before the plain TUI, then attached an external client after that TUI was open. It did not retrofit the embedded TUI, create a replacement conversation, or prove arbitrary blank-TUI attachment. Queue acceptance is submission evidence; the separately observed exact native-TUI reply is test receipt evidence, not a new generic ACK API.
Add the reports and an opt-in, exclusively owned-server experiment harness under
experiments/codex_first_input/. The harness uses existing loaded IDs,thread/read(includeTurns:false)andthread/queue/add; neverthread/start,thread/resume,turn/start, fallback, or uncertain-effect retry. Only selected metadata is reported.includeTurns:falseis not a universal promise that the API has no preview fields.Type
Verification
python3 tools/generate_session_peer.py --check: PASS.python3 -m unittest discover -s tests/docs -t . -v: 60 PASS.git diff --check: PASS.rust-v0.162.1static source review and separate read-only report/harness review: no blocking findings; this is not an additional independent live run or external CLI review.experiments/; no runtime dependency, package metadata, generated standalone, or release change. Websockets 17.0 was installed only in a temporary test environment, then removed. Packaging CI must confirm the existing exclusion.Checklist
cc_peer.pychecklist is not used to claim public runtime support.Verified against
Codex CLI/App Server 0.162.1, macOS arm64, ordinary shared-server TUI selected GPT-6.1-Sol medium. Source baseline: published session-peer v1.1.1 /
b48144bdf2ad1569031562136f5a60e33780020e. Experimental WebSocket client used websockets 17.0. The harness runs only by explicit operator invocation; CI must not launch authenticated real model sessions.Notes / remaining gates
Review corrections for the v1.2.0 preparation
Independent CLI review before the follow-up update
Follow-up: new Codex findings on dc80705 (2026-10-15)
Final head: 5c80632.
Independent CLI static review before pushing:
The two new threads are resolved with implementation/test evidence. Latest-head CI and Codex re-review are requested separately, not claimed complete by this update.
Follow-up: submission payload and queue preflight (2026-10-15)
Final head ec924de addresses the two findings on 5c80632:
Independent CLI review before push:
The two findings are resolved with implementation/source/test explanations; latest-head re-review is requested. No merge, tag, release, publication, runtime installation or operations change.
Storage-authority correction (P1 on ec924de; 2026-10-15)
Exact final head: 97f7df7.
Read-only design consultation confirmed that probe-local environment/root-config checks cannot establish an already-running server's startup SQLite selection. Root's subsequent pinned-source audit also found an important limitation in the proposed server-history replacement: native history can be unavailable before materialization. The implementation and documentation preserve both facts:
Pinned primary sources and these availability/privacy/side-effect distinctions are linked in ORDINARY_TUI.md. The fresh-history fallback and explicit unavailable error were independently source-traced, not exercised on a live native server.
Validation on final head:
Independent CLI static review:
The P1 thread is resolved as a fail-closed safety correction, not by asserting full storage identity or completed empty-TUI support. Current-head CI and Codex automatic re-review are separate gates. No merge/tag/release/publication/native run/runtime install/deployment.