Repository navigation
fix(claude): discover native sessions in Orca account-scoped profiles - #319
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #317. Assigned to the v1.2.1 patch-candidate milestone; this PR does not bump the runtime version or authorize publication.
CLAUDE_CONFIG_DIRnorANTHROPIC_CONFIG_DIRexplicitly selects a root. Explicit-root precedence and scope remain unchanged. Linux/Windows automatic Orca-profile inventory is not added.Validation
Final pre-PR source is identified in the final independent-review record below, based on published v1.2.0/main
4fc526f36afc65bb6ec460439eb0986c09ecc8ee.git diff --check: pass. Frozen handoff document/fixture hashes remain unchanged.The final full test log includes asyncio slow-task debug messages, expected negative-test diagnostics, and an asyncio/websockets accept/teardown
AssertionErrorfollowed by ignored unclosed-socket/transportResourceWarningdiagnostics, despite the test runner reporting OK/exit 0. The first-run log is retained without rerunning to hide these observations. Their causal relationship to this patch is unproven; this is not a warning-free claim and does not resolve the separately tracked shutdown/CI diagnostics in #316. Synthetic inbox/SSH/handoff fixtures do not establish new live send/ACK or Windows native-profile acceptance. Windows reparse-point/cloud-placeholder compatibility has not been established by native acceptance.Independent pre-PR review
The
independent-cli-reviewworkflow was used before PR creation: separate non-interactive Claude Code and Codex CLI processes, the same immutable sanitized stdin packet, no reviewer tools/tests/network/writes, and pre/post SHA-256 verification. Reviewers did not receive one another's outputs. Source findings were checked against the implementation.The first review identified record-filename/socket-alias compatibility, permission reporting and no-effect refusal issues; these were fixed. A follow-up identified different live records claiming the same actual socket through different aliases; the final commit adds an inode-based Unix conflict index and an order-independent regression test.
Final source
4cd202af4b6a2f0b5e7daa1e7f9d960eb7a67217was independently re-reviewed before PR creation:e55e99b092277ec831469df586178e391ef80d8c4b3b1869842316f283bf074d, identical before/after both runs.aa57133c339454ef8cec41d3f68be3c0c19d7c99cd6deb378a0b49ab8d9e718b, first follow-up63c6b76a115267f5216ef1a401fc25af9d1c06510456a2b671b79c9cbb125742. Subsequent review packets did not include one another's reviewer outputs.Scope limits
No merge, tag, release, package publication, global installation, native message experiment or operations change. Queued/posted remains submission evidence, not receipt or completion. Existing inactive-target and no-automatic-retry policies remain in force. PR creation supplies the configured automatic Codex review; no review mention is added.