Repository navigation
fix(skill): read bounded frontmatter independently of document size - #320
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #318. Related #302 / #303. Patch candidate for v1.2.1; no runtime version bump or publication.
The previous metadata reader rejected a whole skill document above 16,384 bytes. Both released Python skill snapshots exceed this limit (v0.3.2: 16,459 bytes; v0.3.3: 18,824 bytes), causing unknown installed version/minimum metadata despite valid small frontmatter.
Verification
Exact pre-PR source:
3b90b7fcff5d1168a180b43394b0cc4e25e38e61, based on published v1.2.0/main4fc526f36afc65bb6ec460439eb0986c09ecc8ee.build --no-isolationfailed because the private build tool environment lacked the pinned hatchling 1.32.4 backend. The failure log was preserved; standard isolated builds supplied that backend without changing the shared environment and final wheel/sdist checks passed.Independent pre-PR review
The requested
independent-cli-reviewused the same frozen sanitized packet in separate parallel non-interactive processes before PR creation, with reviewer tools/tests/network/writes disabled and before/after input hashes checked:3b90b7fcff5d1168a180b43394b0cc4e25e38e61, immutable packet 29,997 bytes, SHA-2561b40533296524c90d51556b01a5960a6c24501ee74c4df8a7d6057a7e0a352ff. Both exit 0 with valid completed responses; input/source unchanged.common.pysuppliesstat; fragments are not independently imported runtime modules) and cache-validation code (fresh cache requires a valid stable version). Those questions do not establish defects.Boundaries
No merge, tag, release, package publication, global installation, skill-source rewrite or operations change. Existing metadata interpretation is not a grant to execute a skill. The configured automatic Codex review is left to run without a mention.