Repository navigation
chore(control): update Vite and Vitest security patches - #327
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repairs the newly reported Control dependency audit failures independently of #325. Based on
mainatf19f2b5e9ac17d392375507bc753548cdfc0e751; the feature branch is not included.control/package-lock.json. Package manifest, direct production pins, application code, workflows, audit thresholds and Node 22/24 engine policy are unchanged. Every changed version's resolved tarball, integrity and engine metadata was compared with its public npm registry metadata.Closes #326. This should unblock dependency auditing for #325 after normal review/merge and rerunning that PR's checks; no merge or deployment is performed here.
Why production audit includes these packages
Better Auth 1.7.5 declares an optional Vitest peer. The selected Vitest/Vite nodes therefore have
devOptionalmetadata and are not excluded simply bynpm audit --omit=dev. This is an audit/dependency-graph finding, not a reproduced exploit or a determination that the deployed Control service exposes a development server.npm 11.15.0 also recalculated classification metadata for 56 unchanged-version entries: platform optional dependencies lose
dev:true, whiletsx,@types/nodeandundici-typesbecomedevOptional. The manifest groups and package-node set stay unchanged, but the derived--omit=devinstallation/audit set can expand. These flags were not hand-edited or reverted to hide advisories. The existing Rollup 4.63.3 node explicitly declares@napi-rs/lzma-linux-x64-gnu@1.5.1as an optional dependency; it is not a new package added by this PR. It is not installed on the macOS test host.Repository development instructions use full
npm ci; no live deployment installation was inspected or changed. Existing platform install scripts still apply. This PR does not claim deployed remediation.Type
Validation
Exact candidate:
d011e595dcc164e6f23c67824b4353b7c5e15987.npm audit --omit=devand fullnpm audit, both exit 0, zero vulnerabilities. Initial advisory-service timeouts are retained as failed attempts, not interpreted as clean results. The successful audits used bounded network timeouts; existing CI audit commands are unchanged.--ignore-scripts --no-auditcompleted successfully; the clean install used--no-auditonly to separate installation from the explicit audits above. No registry/policy/global configuration changes or audit suppressions.git diff --checkpass.Limits
.test.ts, not the existing TSX UI test file; 123 passing tests are not a claim of that UI coverage.