Repository navigation
chore: bump Go to 1.26.10 and go-jose, x/net for CVEs - #643
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #643 +/- ##
==========================================
- Coverage 70.96% 70.90% -0.06%
==========================================
Files 53 53
Lines 5682 5682
==========================================
- Hits 4032 4029 -3
- Misses 1422 1425 +3
Partials 228 228 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Docker workflow's
security-scan(Trivy,HIGH,CRITICAL,ignore-unfixed) fails on the open Dependabot PRs. The findings come frommain, not from the PRs. A rerun of the scan on #641 reports 6 HIGH in the Go binary:The scans from the original Dependabot runs also flagged libcrypto3/libssl3 in the
alpine:3.21base. That is resolved upstream: the rerun pulled alpine 3.21.9, which has 0 findings.What
.tool-versions,docker/Dockerfile.build,go.modtoolchain, docs)github.com/go-jose/go-jose/v44.1.4 → 4.1.6 (indirect, via vault/api)golang.org/x/net0.59.0 → 0.60.0vendor/refreshed; CHANGELOG[Unreleased]entry addedVerification
go test -mod=vendor -race ./...: passdocker build -f docker/Dockerfile.build, then Trivy (aquasec/trivy:latest) with the CI flags: 0 HIGH/CRITICAL on both the alpine layer and the Go binarydocker run confd:scan --versionreportsgo1.26.10