Skip to content

ci: run build, tests, manifest checks and lint on PRs - #112

Closed
abundantbeing wants to merge 1 commit into
mainfrom
chore/ci-verification
Closed

abundantbeing wants to merge 1 commit into
mainfrom
chore/ci-verification

Conversation

@abundantbeing

Copy link
Copy Markdown
Owner

What changed

  • Add a read-only GitHub Actions workflow for PRs targeting main and pushes to main.
  • Use Node 22 and npm ci, then run the Chromium build, npm run verify (including the Firefox pretest build, unit tests, JS and manifest checks), and npm run lint.
  • Cancel superseded runs on the same ref.

Scope and validation

This is the first focused change from the repository review; it does not fix the reported connection, consent, or session bugs. Browser/gateway E2E journeys are deliberately not included because they require dedicated runtime setup. I have not executed this workflow locally; check the GitHub Actions result before marking ready or merging.

@abundantbeing abundantbeing added comp/build Build/package/manifest/version metadata and verification scripts comp/gateway Hermes gateway lifecycle, runtime connection, logs, local service behavior comp/sessions Session list, source grouping, create/resume/history behavior comp/settings Settings panel, connection setup, privacy/config controls p3 Low: minor bug, polish, docs, duplicate, or follow-up type/bug Something is not working labels Sep 23, 2026
@abundantbeing

Copy link
Copy Markdown
Owner Author

Hermes Agent Review

Summary

PR #112 adds a read-only GitHub Actions workflow (.github/workflows/ci.yml) triggering on pushes and pull requests targeting main. It sets Node.js 22 with npm caching, runs npm ci, and executes npm run build, npm run verify, and npm run lint under a 20-minute timeout with contents: read permissions.

Blocking issues

Nothing in the workflow configuration structurally blocks merge. However, merge cannot be approved at this time because no check run results are present in the event data, and the workflow has not yet been verified against live CI execution.

Suggestions

  • For concurrency, consider scoping cancellation to pull requests via cancel-in-progress: ${{ github.event_name == 'pull_request' }} so pushes landing on main run through to completion.
  • Consider using group: ci-${{ github.workflow }}-${{ github.head_ref || github.ref }} for explicit branch-based grouping on pull requests.
  • Verify whether npm run verify already executes the build step to prevent duplicate build work during CI execution.

Checks to run

  • Run the workflow on this PR and confirm that .github/workflows/ci.yml triggers as expected.
  • Confirm npm ci completes successfully against the checked-in package-lock.json on Node 22.
  • Verify that npm run build, npm run verify, and npm run lint exit cleanly with status code 0 on ubuntu-latest.

Notice: This review is automated and AI-generated.


Automated review by Hermes Agent. Diffs/issues are treated as untrusted input.

Reviewed signature: 5f2ee7ec33b6394102a4e4d499c4390af1c802909ce32cca744633c00fdea60d

@abundantbeing

Copy link
Copy Markdown
Owner Author

Closing this draft. Verification stays local with npm run build, npm run verify, and npm run lint. This repo does not run GitHub Actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/build Build/package/manifest/version metadata and verification scripts comp/gateway Hermes gateway lifecycle, runtime connection, logs, local service behavior comp/sessions Session list, source grouping, create/resume/history behavior comp/settings Settings panel, connection setup, privacy/config controls p3 Low: minor bug, polish, docs, duplicate, or follow-up type/bug Something is not working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant