Orders v2026‑01‑01#924
Merged
Merged
Conversation
|
There was a problem hiding this comment.
Pull request overview
Integrates the new Orders API version 2026-01-01 into the library by adding a dedicated service, request parameters, URL endpoints, rate-limit definitions, and a large set of new/updated SDK models/enums for that version.
Changes:
- Added
OrderServiceV20260101withSearchOrdersandGetOrderoperations, plus wiring viaAmazonConnection. - Extended URL routing (
ApiUrls) and rate limiting (RateLimitType,RateLimitsDefinitions) for the new endpoints. - Introduced extensive
OrdersV20260101models/enums to represent the v2026-01-01 schema.
Reviewed changes
Copilot reviewed 79 out of 79 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Source/FikaAmazonAPI/Utils/RateLimitsDefinitions.cs | Adds rate-limit values for the new Orders v2026-01-01 endpoints. |
| Source/FikaAmazonAPI/Utils/RateLimitType.cs | Adds new enum values used to key rate limiting for v2026-01-01 calls. |
| Source/FikaAmazonAPI/Services/OrderServiceV20260101.cs | New service implementing SearchOrders and GetOrder for Orders v2026-01-01. |
| Source/FikaAmazonAPI/Services/ApiUrls.cs | Adds v2026-01-01 Orders endpoint URL builders. |
| Source/FikaAmazonAPI/Parameter/Order/V20260101/ParameterSearchOrders.cs | Adds parameter object for SearchOrders query construction. |
| Source/FikaAmazonAPI/Parameter/Order/V20260101/ParameterGetOrder.cs | Adds parameter object for GetOrder query/path construction. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/UnitEnum.cs | New enum for measurement units in v2026-01-01 models. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/TimeWindow.cs | New model supporting delivery time window structures. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/Time.cs | New model for business open/close times. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/SubstitutionTypeEnum.cs | New enum for substitution preference sources. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/SubstitutionPreference.cs | New model for order-item substitution preferences. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/SubstitutionOption.cs | New model describing allowed substitute items. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/ShippingConstraints.cs | New model for shipping constraints metadata. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/Shipping.cs | New model for per-item shipping details. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/SearchOrdersResponse.cs | New response model for SearchOrders. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/SalesChannel.cs | New model describing the ordering channel/marketplace info. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/Recipient.cs | New model for delivery recipient information. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/PromotionBreakdown.cs | New model for promotion breakdown entries. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/Promotion.cs | New model for promotions applied to items/orders. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/ProgramEnum.cs | New enum for order programs. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/ProceedsBreakdownTypeEnum.cs | New enum for proceeds breakdown type. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/ProceedsBreakdownSubtypeEnum.cs | New enum for proceeds breakdown subtype. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/PriceDesignationEnum.cs | New enum for price designation. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/Price.cs | New model for per-unit price and designation. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/PointsGranted.cs | New model for points granted. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/PointsCost.cs | New model for points cost wrapper. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/Picking.cs | New model for picking-stage metadata. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/Pagination.cs | New model for pagination tokens in v2026-01-01 responses. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/Packing.cs | New model for packing-stage metadata. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/PackageStatusEnum.cs | New enum describing package status. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/PackageStatus.cs | New model describing package status + detailed status. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/PackageItem.cs | New model for items within a shipped package. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/PackageDetailedStatusEnum.cs | New enum for granular package detailed statuses. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/OrderProceeds.cs | New model for order-level proceeds. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/OrderItemProgramEnum.cs | New enum for item-level programs. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/OrderItemProceedsDetailedBreakdown.cs | New model for detailed proceeds breakdown lines. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/OrderItemProceedsBreakdown.cs | New model for proceeds breakdown grouping. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/OrderItemProceeds.cs | New model for item-level proceeds. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/OrderItemFulfillment.cs | New model for item-level fulfillment state. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/OrderItemCustomization.cs | New model for custom/personalized order item metadata. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/OrderFulfillment.cs | New model for order-level fulfillment metadata. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/OrderAssociationTypeEnum.cs | New enum for associated-order relationship type. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/OrderAliase.cs | New model for alternate order identifiers (but currently misspelled). |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/Money.cs | New model for money amounts/currency. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/Measurement.cs | New model for measurement unit/value. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/InternationalShipping.cs | New model for international shipping requirements. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/IncludedDataEnum.cs | New enum controlling response datasets returned. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/GiftOption.cs | New model for gift options. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/GetOrderResponse.cs | New response model for GetOrder. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/FulfillmentStatusEnum.cs | New enum for fulfillment status values. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/FulfillmentServiceLevelEnum.cs | New enum for fulfillment service level values. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/FulfilledByEnum.cs | New enum for fulfillment party. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/Expense.cs | New model for item expense details. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/ExceptionDateTypeEnum.cs | New enum for exception date open/closed states. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/ExceptionDate.cs | New model for delivery exception dates. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/EnforcementLevelEnum.cs | New enum for enforcement level. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/DeliveryWindow.cs | New model for delivery windows (has an unused using). |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/DeliveryTime.cs | New model for delivery time preferences. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/DeliveryPreference.cs | New model for delivery preferences. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/DayOfWeekEnum.cs | New enum for day-of-week codes. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/ConditionTypeEnum.cs | New enum for item condition type. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/ConditionSubtypeEnum.cs | New enum for item condition subtype. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/Condition.cs | New model for item condition details. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/ChannelTypeEnum.cs | New enum for channel type. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/CancellationRequesterEnum.cs | New enum for cancellation requester. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/CancellationRequest.cs | New model for cancellation request details. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/Cancellation.cs | New model for cancellation information. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/Buyer.cs | New model for buyer information. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/BusinessHour.cs | New model for business hours windows. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/AssociatedOrder.cs | New model for associated orders. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/AliasTypeEnum.cs | New enum for alias type. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/AddressTypeEnum.cs | New enum for address type. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/OrdersV20260101/AddressExtendedFields.cs | New model for extended address fields. |
| Source/FikaAmazonAPI/AmazonConnection.cs | Wires OrderServiceV20260101 into the main client entry point. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+90
to
+109
| ) && | ||
| ( | ||
| this.Amount == input.Amount || | ||
| (this.Amount != null && | ||
| this.Amount.Equals(input.Amount)) | ||
| ); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Gets the hash code | ||
| /// </summary> | ||
| /// <returns>Hash code</returns> | ||
| public override int GetHashCode() | ||
| { | ||
| unchecked // Overflow is fine, just wrap | ||
| { | ||
| int hashCode = 41; | ||
| if (this.Amount != null) | ||
| hashCode = hashCode * 59 + this.Amount.GetHashCode(); | ||
| if (this.CurrencyCode != null) |
There was a problem hiding this comment.
Amount is a non-nullable decimal, but the generated equality/hash code logic includes this.Amount != null checks. This produces always-true comparisons (and CS0472 warnings) and should be simplified to compare/hash the value directly (and similarly for other non-nullable value-type fields).
| @@ -0,0 +1,136 @@ | |||
| using FikaAmazonAPI.AmazonSpApiSDK.Models.ShippingV2; | |||
There was a problem hiding this comment.
This using appears unused in this file. Removing it will avoid unnecessary dependencies and compiler warnings.
Suggested change
| using FikaAmazonAPI.AmazonSpApiSDK.Models.ShippingV2; |
Comment on lines
+12
to
+16
| /// Alternative identifier that can be used to reference order. | ||
| /// </summary> | ||
| [DataContract] | ||
| public partial class OrderAliase : IEquatable<OrderAliase>, IValidatableObject | ||
| { |
There was a problem hiding this comment.
The model name OrderAliase looks like a typo (should likely be OrderAlias). Since this is part of the public SDK surface, please rename the type (and file) and update references (e.g., Order.OrderAliases) to avoid locking in the misspelling.
|
How long until this pull request is approved @abuzuhri ? Thank you in advace. |
Owner
|
its approve can you test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrated Orders v2026‑01‑01 including models with full parameter and field descriptions, and added all possible ENUMs, following the library design.