Skip to content

Fix batch pricing API: flatten queryParams to top-level properties (Amazon API contract change 2026-04-23) #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abuzuhri merged 1 commit into from
Apr 25, 2026
Merged

Fix batch pricing API: flatten queryParams to top-level properties (Amazon API contract change 2026-04-23) #929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 8 additions & 16 deletions Source/FikaAmazonAPI/Parameter/ProductPricing/ItemOffersRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,25 +28,17 @@ public string Uri
[JsonProperty("method")]
public HttpMethodEnum HttpMethod { get; set; }

//[JsonProperty("headers")]
//public Dictionary<string, string> Headers { get; set; }

[JsonProperty("queryParams")]
// Amazon changed their batch API contract: query params must be serialized at the top level, not nested under "queryParams".
[JsonIgnore]
public ParameterGetItemOffers QueryParams { get; set; }

///// <summary>
///// A marketplace identifier. Specifies the marketplace for which prices are returned.
///// </summary>
//[DataMember(Name = "MarketplaceId")]
//public string MarketplaceId { get; set; }

//[DataMember(Name = "ItemCondition")]
//public ItemCondition ItemCondition { get; set; }
[JsonProperty("MarketplaceId")]
public string MarketplaceId => QueryParams?.MarketplaceId;

//[DataMember(Name = "CustomerType")]
//public CustomerType? CustomerType { get; set; }
[JsonProperty("ItemCondition")]
public ItemCondition ItemCondition => QueryParams?.ItemCondition ?? default;

//[JsonIgnore]
//public string Asin { get; set; }
[JsonProperty("CustomerType")]
public CustomerType? CustomerType => QueryParams?.CustomerType;
}
}
15 changes: 11 additions & 4 deletions Source/FikaAmazonAPI/Parameter/ProductPricing/ListingOffersRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,17 @@ public string Uri
[JsonProperty("method")]
public HttpMethodEnum HttpMethod { get; set; }

//[JsonProperty("headers")]
//public Dictionary<string, string> Headers { get; set; }

[JsonProperty("queryParams")]
// Amazon changed their batch API contract: query params must be serialized at the top level, not nested under "queryParams".
[JsonIgnore]
public ParameterGetListingOffers QueryParams { get; set; }

[JsonProperty("MarketplaceId")]
public string MarketplaceId => QueryParams?.MarketplaceId;

[JsonProperty("ItemCondition")]
public ItemCondition ItemCondition => QueryParams?.ItemCondition ?? default;

[JsonProperty("CustomerType")]
public CustomerType? CustomerType => QueryParams?.CustomerType;
}
}
Loading