fix(parameter-based): respect [EnumMember] attribute when serialising enum query parameters

[ProNotion]

Summary

• ParameterBased.getParameters() was calling .ToString() on enum values, producing the C# identifier name (e.g. FINANCIALEVENTGROUPID) instead of the wire format declared via [EnumMember(Value = "...")] (e.g. FINANCIAL_EVENT_GROUP_ID). Amazon APIs silently reject the malformed values, making every enum-typed query parameter effectively broken when the C# member name differs from the API wire value.
• Fixed by using StringEnumConverter (Newtonsoft.Json) in both the scalar enum branch and the IEnumerable<TEnum> branch, consistent with the fallback path that was already doing this correctly for other types.
• relatedIdentifierName on ParameterListFinancialTransactions20240619 is now typed as RelatedIdentifierNameEnum? instead of string?, taking advantage of the fixed serialisation.

Root cause

// Before - ignores [EnumMember(Value = "FINANCIAL_EVENT_GROUP_ID")]
else if (p.PropertyType.IsEnum || IsNullableEnum(p.PropertyType))
{
    output = value.ToString();  // produces "FINANCIALEVENTGROUPID"
}

// After - respects [EnumMember] attribute
else if (p.PropertyType.IsEnum || IsNullableEnum(p.PropertyType))
{
    var enumSettings = new JsonSerializerSettings
    {
        Converters = new List<JsonConverter> { new StringEnumConverter() }
    };
    output = JsonConvert.SerializeObject(value, enumSettings).Trim('"');
}

Test plan

• Build passes with 0 errors (dotnet build)
• Verify that ParameterListFinancialTransactions20240619 with relatedIdentifierName = RelatedIdentifierNameEnum.FINANCIALEVENTGROUPID produces relatedIdentifierName=FINANCIAL_EVENT_GROUP_ID in the query string
• Check other enum-typed parameters in other ParameterBased subclasses produce their expected wire values

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud