fix: throw Template::Exception on WHILE loop termination#341
Draft
Koan-Bot wants to merge 1 commit intoabw:masterfrom
Draft
fix: throw Template::Exception on WHILE loop termination#341Koan-Bot wants to merge 1 commit intoabw:masterfrom
Koan-Bot wants to merge 1 commit intoabw:masterfrom
Conversation
…ation
Replace bare die string with $context->throw('while', ...) so template
authors can catch runaway WHILE loops with TRY/CATCH blocks using
a typed exception instead of getting an unrecoverable error.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
WHILE loop termination now throws a
Template::Exceptionwith typewhileinstead of a barediestring.Why
Previously, a runaway WHILE loop produced a bare die string that couldn't be selectively caught. Template authors had to catch all exceptions with
CATCH— there was no way to distinguish a WHILE timeout from other errors. With a typed exception,CATCH whileworks as expected.How
Changed the generated code in
Directive::while()fromdie "..."to$context->throw('while', "..."). The$contextvariable is already available in template scope.Testing
t/while.t: verifyCATCH whilecatches the exception, and that non-matchingCATCH foodoes not🤖 Generated with Claude Code