fix: remove redundant regex substitution in Plugins.pm#343
Draft
Koan-Bot wants to merge 1 commit intoabw:masterfrom
Draft
fix: remove redundant regex substitution in Plugins.pm#343Koan-Bot wants to merge 1 commit intoabw:masterfrom
Koan-Bot wants to merge 1 commit intoabw:masterfrom
Conversation
Line 185 already performs `($file = $module) =~ s|::|/|g` which assigns $module to $file and replaces all `::` with `/` in a single operation. Line 186 repeated the same substitution on $file, which is a no-op since all `::` occurrences were already replaced. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove a duplicate
$file =~ s|::|/|gsubstitution in the PLUGIN_NAME path of_load().Why
Line 185 already does
($file = $module) =~ s|::|/|g, which assigns and substitutes in one expression. Line 186 repeated the exact same substitution — a no-op since all::were already replaced.How
Deleted the redundant line 186.
Testing
Full test suite passes (2961 tests, 107 files).
🤖 Generated with Claude Code