Fix printf dash-arg bug in setup.sh and agent-wizard.sh#28
Closed
Fix printf dash-arg bug in setup.sh and agent-wizard.sh#28
Conversation
Bare `printf '->'` causes bash to interpret the leading dash as an option flag, producing "invalid option" errors. Use `printf '%s' '->'` instead, matching the fix already applied in install.sh. Add a regression test that scans all scripts/*.sh files for bare printf calls with dash-prefixed arguments. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
|
Closing — this fix was already merged to main via commit 7108420. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
printf '->'bash bug inscripts/setup.shandscripts/agent-wizard.sh—printfinterprets the leading-as an option flag, producingprintf: ->: invalid optionprintf '%s' '->'is already used inscripts/install.sh; this applies the same fix to the remaining two scriptsscripts/*.shfor bareprintf '-…'patternsTest plan
scripts-printf-safety.test.tsregression test passes🤖 Generated with Claude Code