Skip to content

test(sdk): cover browser DOM integrations - #654

Open
ndyugwu wants to merge 1 commit into
accensa:mainfrom
ndyugwu:issue-569-give-sdk-tests-a-dom
Open

ndyugwu wants to merge 1 commit into
accensa:mainfrom
ndyugwu:issue-569-give-sdk-tests-a-dom

Conversation

@ndyugwu

@ndyugwu ndyugwu commented Oct 17, 2026

Copy link
Copy Markdown

Adds opt-in jsdom coverage for offline sync, the checkout widget lifecycle, and the client SSE stream while preserving Node as the default test environment. Fixes checkout-widget message listener cleanup so the exact registered callback is removed.\n\nValidation: SDK suite (464 passed, 1 skipped), SDK typecheck, and targeted formatting check.\n\nCloses #569

@vercel

vercel Bot commented Oct 17, 2026

Copy link
Copy Markdown

@Cjay-Cyber-2 is attempting to deploy a commit to the ACCENSA Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Oct 17, 2026

Copy link
Copy Markdown

@ndyugwu Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@mergekeeper

mergekeeper Bot commented Oct 17, 2026

Copy link
Copy Markdown

MergeKeeper review unavailable

AI provider failed: gemini-3.5-flash-lite (200)

No approval or merge action was taken.

@coderabbitai

coderabbitai Bot commented Oct 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 47 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9aa16ef0-e080-4336-b3b7-0354b2cf5e3a
📥 Commits

Reviewing files that changed from the base of the PR and between e02ecc2 and 93f156d.

⛔ Files ignored due to path filters: 1
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing: 6
  • packages/sdk/package.json
  • packages/sdk/src/client.stream.dom.test.ts
  • packages/sdk/src/offline-sync.dom.test.ts
  • packages/sdk/src/widget/checkout-widget.dom.test.ts
  • packages/sdk/src/widget/checkout-widget.ts
  • packages/sdk/vitest.config.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants