Add helper for detecting ad blocker interference with wallet connection#407
Merged
Conversation
…cker-interference Add wallet connection stall detection and ad-blocker hint
|
@sochima2 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description
Add useWalletConnectionStallDetection hook in src/hooks/useWalletConnectionStallDetection.ts with a named timeout constant WALLET_CONNECTION_STALL_TIMEOUT_MS and shared message WALLET_CONNECTION_AD_BLOCKER_MESSAGE.
Wire the hook into ConnectWalletButton and WalletConnectCalloutBanner so the ad-blocker suggestion appears only when a wallet connection/reconnect remains pending past the timeout and is cleared when the attempt succeeds or fails.
Add unit tests in src/hooks/tests/useWalletConnectionStallDetection.test.ts covering the stalled, success-before-timeout, and failure-before-timeout behaviors.
Testing
Testing
Ran pnpm exec vitest run src/hooks/tests/useWalletConnectionStallDetection.test.ts, and the new tests passed.
Ran pnpm lint and pnpm build, both completed successfully.
A broader pnpm test invocation that ran the full suite surfaced pre-existing unrelated failures (missing test deps and unrelated assertions) which are not caused by this change.
pnpm lintpnpm buildChecklist
close #406