Skip to content

Fix issue 275#389

Closed
razeprasine wants to merge 3 commits into
accesslayerorg:mainfrom
razeprasine:fix-issue-275
Closed

Fix issue 275#389
razeprasine wants to merge 3 commits into
accesslayerorg:mainfrom
razeprasine:fix-issue-275

Conversation

@razeprasine
Copy link
Copy Markdown
Contributor

@razeprasine razeprasine commented Jun 2, 2026

Summary

  • Added a regression test covering the buy execution path for an unregistered creator.
  • Verified the call reverts with the expected not-registered creator error.
  • Ensured no supply, balance, or fee state changes occur after the failed call.

Testing

  • cargo fmt --all -- --check
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo test --workspace

Closes #275

Checklist

  • Linked issue or backlog item
  • Added or updated creator-keys unit/integration tests for every changed contract behavior
  • Ran cargo fmt --all -- --check, cargo clippy --workspace --all-targets -- -D warnings, and cargo test --workspace
  • Reviewed persistent storage changes against docs/storage-key-invariants.md
  • Confirmed event names, topic order, payload field order, and field meanings remain compatible with docs/contract-event-conventions.md
  • Updated docs for any changed public contract interface
  • Scope stays limited to one contract concern

@Chucks1093 Chucks1093 closed this Jun 2, 2026
@Chucks1093 Chucks1093 reopened this Jun 2, 2026
@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented Jun 2, 2026

@razeprasine Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Chucks1093
Copy link
Copy Markdown
Contributor

Hi @razeprasine, same CI failure here as in #388 — the base32_encode function in creator-keys/tests/contract_test_env/mod.rs is missing its closing brace }. See the comment on #388 for the exact fix. Once you push the fix CI should pass on this one too.

Also note: the PR body has been updated to include Closes #275 so the issue will auto-close when this merges.

@Chucks1093 Chucks1093 closed this Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add regression test for buy revert when creator is not registered

2 participants