Add config masking helper and creator-list integration tests#323
Closed
ritik4ever wants to merge 4 commits into
Closed
Add config masking helper and creator-list integration tests#323ritik4ever wants to merge 4 commits into
ritik4ever wants to merge 4 commits into
Conversation
|
@ritik4ever Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
- Add maskSensitiveConfig helper in startup.utils to redact sensitive config values by key pattern (secret, password, token, credential, API key). - Apply masking helper to a new startup configuration summary log in server.ts. - Add integration test for concurrent creator list requests verifying consistent results (issue #312). - Add integration test for creator route with malformed wallet address param verifying 400 on wrong-length and invalid-character variants (issue #299). - Add integration test for creator list response shape consistency across page sizes 1, 10, and MAX_PAGE_SIZE (issue #317). Closes #300 Closes #312 Closes #299 Closes #317
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #300 — Sensitive config value masking
maskSensitiveConfig()tosrc/utils/startup.utils.ts— accepts a config record and redacts values whose keys match sensitive patterns (secret,password,token,credential,DATABASE_URL,_API_KEY)src/server.tsIssue #312 — Concurrent creator list consistency
src/modules/creators/creator-feed-concurrent-requests.integration.test.tshttpListCreatorscalls and asserts identical item sets, pagination metadata, andhasMore/totalvaluesIssue #299 — Malformed wallet address param
src/modules/creator/creator-profile-malformed-params.integration.test.tscreatorIdparams all return HTTP 400 withVALIDATION_ERRORdetailswithfieldandmessageIssue #317 — Response shape consistency across page sizes
src/modules/creators/creator-list-response-shape-consistency.integration.test.tslimit=1,10, andMAX_PAGE_SIZE(100)success,data), data envelope keys (items,meta), and meta keys (limit,offset,total,hasMore)items.lengthmatches the requested page sizeVerification
Closes Add helper for masking sensitive config values in startup summary log #300
Closes Add integration test for concurrent creator list requests returning consistent results #312
Closes Add integration test for creator route with malformed wallet address param #299
Closes Add integration test for creator list response shape consistency across page sizes #317