Skip to content

fix: throw Error instead of raw array for TypeScript compilation fail… #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sup-ri-tha wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −81
Open

fix: throw Error instead of raw array for TypeScript compilation fail… #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/TemplateMarkToJavaScriptCompiler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,11 @@ export class TemplateMarkToJavaScriptCompiler {
return compiled;
}
else {
throw errors;
const messages = errors.map(e => {
const errorList = e.errors.map(d => `${d.renderedMessage} (line ${d.line}, col ${d.character})`);
return `In '${e.nodeId}': ${errorList.join(', ')}`;
});
throw new Error(messages.join('\n'));
Copy link

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Throwing an Error here fixes the raw-array issue, but it also drops the structured compilation details (nodeId/code/diagnostics) that callers may want to inspect programmatically. Consider attaching the original errors array onto the Error object (similar to TemplateMarkInterpreter.checkTypes, which sets (error as any).errors = errors) or using ErrorOptions.cause where supported, so consumers can access rich data without parsing the message string.

Suggested change
throw new Error(messages.join('\n'));
const error = new Error(messages.join('\n'));
(error as any).errors = errors;
throw error;

Copilot uses AI. Check for mistakes.
}
}
}
82 changes: 2 additions & 80 deletions test/__snapshots__/TemplateMarkInterpreter.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,86 +1,8 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`templatemark interpreter should fail to generate formula-invalid 1`] = `
[
{
"code": " THIS IS GARBAGE ",
"errors": [
{
"category": 1,
"character": 3,
"code": 2304,
"id": "err-2304-468-4",
"length": 4,
"line": 82,
"renderedMessage": "Cannot find name 'THIS'.",
"start": 1785,
},
{
"category": 1,
"character": 8,
"code": 2304,
"id": "err-2304-473-2",
"length": 2,
"line": 82,
"renderedMessage": "Cannot find name 'IS'.",
"start": 1790,
},
{
"category": 1,
"character": 11,
"code": 2304,
"id": "err-2304-476-7",
"length": 7,
"line": 82,
"renderedMessage": "Cannot find name 'GARBAGE'.",
"start": 1793,
},
{
"category": 1,
"character": 3,
"code": 1435,
"id": "err-1435-468-4",
"length": 4,
"line": 82,
"renderedMessage": "Unknown keyword or identifier. Did you mean 'this'?",
"start": 1785,
},
{
"category": 1,
"character": 8,
"code": 1434,
"id": "err-1434-473-2",
"length": 2,
"line": 82,
"renderedMessage": "Unexpected keyword or identifier.",
"start": 1790,
},
],
"nodeId": "formula_adef0feb9fc1b6e7513409c93d86aa4d9999d35608e1aaeecc07dca99bc591c8",
},
]
`;
exports[`templatemark interpreter should fail to generate formula-invalid 1`] = `[Error: In 'formula_adef0feb9fc1b6e7513409c93d86aa4d9999d35608e1aaeecc07dca99bc591c8': Cannot find name 'THIS'. (line 82, col 3), Cannot find name 'IS'. (line 82, col 8), Cannot find name 'GARBAGE'. (line 82, col 11), Unknown keyword or identifier. Did you mean 'this'? (line 82, col 3), Unexpected keyword or identifier. (line 82, col 8)]`;

exports[`templatemark interpreter should fail to generate formula-no-method 1`] = `
[
{
"code": " return message.missing() ",
"errors": [
{
"category": 1,
"character": 18,
"code": 2339,
"id": "err-2339-483-7",
"length": 7,
"line": 82,
"renderedMessage": "Property 'missing' does not exist on type 'string'.",
"start": 1800,
},
],
"nodeId": "formula_4ef52e3adc6e5334e0925838eed0e51a372091d9b3a4499537ccf82fce5b1b25",
},
]
`;
exports[`templatemark interpreter should fail to generate formula-no-method 1`] = `[Error: In 'formula_4ef52e3adc6e5334e0925838eed0e51a372091d9b3a4499537ccf82fce5b1b25': Property 'missing' does not exist on type 'string'. (line 82, col 18)]`;

exports[`templatemark interpreter should fail to generate formula-optional-noguard 1`] = `[Error: Optional properties used without guards: message]`;

Expand Down