chore: fix no-floating-promises and prefer-const lint rules#843
Closed
Shreyaskulkarni56 wants to merge 2 commits intoaccordproject:mainfrom
Closed
chore: fix no-floating-promises and prefer-const lint rules#843Shreyaskulkarni56 wants to merge 2 commits intoaccordproject:mainfrom
Shreyaskulkarni56 wants to merge 2 commits intoaccordproject:mainfrom
Conversation
Signed-off-by: Shreyas <shreyaskulkarni051@gmail.com>
✅ Deploy Preview for ap-template-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #697
Summary
Fixes ESLint warning related to
no-floating-promisesin TemplateMarkdown handleChange and improves code quality by addressingprefer-constwhere applicable.Changes
no-floating-promisesruleletwithconstwhere variables are not reassignedFlags
Screenshots or Video
N/A
Related Issues
no-floating-promiseserror in TemplateMarkdown handleChange #697Author Checklist
--signoffoption of git commit.mainfromfork:fix-lint-warnings