cleanup: remove deprecated show_progress_bar logic #1583#1601
cleanup: remove deprecated show_progress_bar logic #1583#1601AviJxn wants to merge 1 commit intoaces:masterfrom
Conversation
AviJxn
force-pushed
the
cleanup/remove-progress-bar-1583
branch
from
867f953 to
927725e
Compare
| return {:color => color, :progress => progress, :message => nil, :show_percentage => false } | ||
| end | ||
|
|
||
| # Returns true if progress bar has to be shown. Task must override this method |
There was a problem hiding this comment.
That is insufficient. Please review the subsystem carefully, you are currently leaving other dead code in the code base. It's not enough just to remove lines, you need to understand how these lines are integrated with the rest of the codebase.
AviJxn
force-pushed
the
cleanup/remove-progress-bar-1583
branch
from
57bebf5 to
96dea91
Compare
|
Thank you for the feedback @prioux . You were absolutely right that removing the view was not enough. I have now performed a full audit of the subsystem and decommissioned the "progress_info" and "show_progress_bar?" methods from "PortalTask" along with the legacy documentation. I have verified via a project wide search that no other components depend on this code. I have amended the PR into a single clean commit to ensure the cleanup is complete. I appreciate the guidance! 
|
2 participants
This PR performs a surgical cleanup of the dead code associated with the deprecated "show_progress_bar" feature as discussed in #1583. Following recent updates to the "cbrain-plugins-psom" repository I have removed the "show_progress_bar?" method from the "PortalTask" model and the corresponding rendering logic from the task information view. These changes are strictly limited to the scope of the issue to ensure codebase stability.