Handle provider rename failures in UserfilesController (#1436)#1603
Open
AviJxn wants to merge 1 commit intoaces:masterfrom
Open
Handle provider rename failures in UserfilesController (#1436)#1603AviJxn wants to merge 1 commit intoaces:masterfrom
AviJxn wants to merge 1 commit intoaces:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have updated the "update" action in the "UserfilesController" to properly handle cases where a file rename fails on the backend. Previously, the system would log a success message even if the storage provider rejected the change (usually due to a name collision).
By wrapping the "provider_rename" call in a conditional check, the controller now captures these failures. If the rename does not go through, it populates the "@userfile.errors" array with a specific warning. This ensures the UI stays in sync with the actual storage state, suppressing the "Success" flash message and letting the user know exactly what went wrong. I have verified the logic using a mock test suite to simulate provider level rejections.
issues #1436