IV gradient fix to main (v1.3.2)#303
Merged
Merged
Conversation
rohandahale
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks the IV (Stokes I+V) imaging gradient fix to
mainas a patch release, and bumps the version to 1.3.2.chisqgrad_vvis/chisqgrad_vvis_nfftdropped the physical ρ-gradient forpol='IV'imaging (thevcvtransform couples the V solver variable to both ρ and ψ, and the dominantdρ/dv'term was skipped). The V-angle gradient was ~99% wrong on released numpy IV imaging. Fix: compute the ρ-gradient whenever V is solved (pol_solve[1] or pol_solve[3]).mainis pre-refactor and has notests/infrastructure, so this is the 2-line source fix only. The FD regression test (test_iv_gradient_matches_finite_difference) lives on the refactored branches.Same fix already merged to
dev(#296),dev-backend(#299), anddev-backend-mixpol(#300); FD-validated there (analytic vs central differences, median ~3e-10 after vs ~99% wrong before). This completes the cascade tomain.Bumps
pyproject.tomlversion + download URL 1.3.1 → 1.3.2. Ready for tagging.