Fix window resize issue#1
Open
faizkhan12 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Fix: Resizing Issue with Circle and Line Intersection on Canvas
##PROBLEM
This PR addresses an issue in the current implementation of our canvas-based UI where a circle is drawn with a line intersecting at its base. The problem arises when the canvas is resized. In the current state, upon resizing the window, the line overflows and does not maintain its correct position relative to the circle. This misalignment persists until the page is refreshed, which is not an ideal user experience.
##SOLUTION
To resolve this I have implemented a window.addEventListener('resize'), isolates the drawMainCircle and drawConnectingLine in one separate function and passes it to window.addEventListener('resize')
##IMPACT
This fix enhances the user experience by ensuring that the visual elements on our canvas remain consistent and correctly positioned across various window sizes. It promotes a more dynamic and responsive design, adapting to changes in the browser window's dimensions immediately.