SMCBatteryManager improvements#81
Merged
Merged
Conversation
…ery is full The AC adapter may provide insufficient power, so the battery may be actually discharging
vit9696
reviewed
Apr 9, 2026
Contributor
vit9696
left a comment
vit9696
left a comment
There was a problem hiding this comment.
Looks good to me, left a tiny note regarding style.
Please fix this and update Changelog.md file.
Feel free to merge afterwards.
added 2 commits
April 9, 2026 16:43
This prevents repeated "PMRD: clamshell closed 0, disabled 0/0, desktopMode 0, ac 0" messages in kernel log
usr-sse2
force-pushed
the
power-notifications
branch
from
fde6570 to
e63277b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PMRD: clamshell closed 0, disabled 0/0, desktopMode 0, ac 0spam in kernel log.In this case the battery is fully charged, external power source is connected, but the battery is actually draining, so we need to refresh its status periodically, or else it will continue to show 100% until the power is disconnected or it is drained completely.