(Critical) Bug fix: Controller parentLink pop-out phenomenon - #64
Open
createsejin wants to merge 1 commit into
Open
(Critical) Bug fix: Controller parentLink pop-out phenomenon#64createsejin wants to merge 1 commit into
createsejin wants to merge 1 commit into
Conversation
Owner
|
Oops for the reversed one! But animating parented controllers is by design, this allows making animations relative to a parent. Which can be useful (although it's preferable to use Timeline's built-in parenting) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a critical issue where controllers would "pop out" or snap incorrectly when using parenting features alongside Timeline.
Technical Details
1. Fix incorrect state retrieval
In
src/AtomAnimations/Animatables/FreeControllerV3s/FreeControllerV3AnimationTarget.cs, theGetRotationParentRB()method was incorrectly retrieving the Position State instead of the Rotation State. This has been corrected to retrieve the proper Rotation State.2. Resolve conflict with VaM's built-in parenting
In
src/AtomAnimations/Animations/AtomAnimation.Playback.cs, I modified bothSampleParentedControllersandSampleControllermethods.The logic has been updated to check if the controller's current state is
ParentLinkorPhysicsLink. If either of these states is active, Timeline will now skip overwriting the position and rotation values. This allows VaM's built-in parent/physics system to take full control of the controller without interference from Timeline.Results
These changes resolve the conflict between Timeline and VaM's built-in controller system.
ParentLinkorPhysicsLinkwithout experiencing the "pop out" issue, even if the controller is registered as a Timeline target.