-man switch behavior fixed; Release Notes pdf added#1
Open
-man switch behavior fixed; Release Notes pdf added#1
Conversation
jazan12
reviewed
Jul 9, 2020
| print "\nUser Response to: Is this an NSM? is: $nsm_q\n"; | ||
|
|
||
| # Now given that this is a Full stop, it could be a Normal Sun Mode or bright start hold. We | ||
| # need to record th epitch attitude that the spacecraft is presently in due to the stop. |
jazan12
approved these changes
Jul 9, 2020
jazan12
left a comment
jazan12
left a comment
There was a problem hiding this comment.
A minute typo in your code comments is all I've got for you. Looks good to me.
taldcroft
reviewed
Jul 16, 2020
| # Example Status Array: 2002:281:01:43:57.095 HRC-S,HETG-OUT,LETG-OUT,2118,OORMPDS,CSELFMT2,ENAB | ||
| # | ||
| #################################################################### | ||
| my $NLET_cmd = "/proj/sot/ska/bin/python /data/acis/LoadReviews/script/NONLOADEVENTTRACKER/RecordNonLoadEvent.py $choice --source history_files.pl "; |
There was a problem hiding this comment.
This code should be migrated to Ska3 at some point in the not-too-distant future. The legacy Ska Python 2 is no longer being maintained.
Contributor
Author
There was a problem hiding this comment.
Agreed. As a matter of fact several program are being migrated to ska3 and this one is included. But not in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new repo for history-files.pl includes an update to the program to fix the behavior of the -man switch; limiting it's operation to maneuver-only loads.
More informational messages for the user were added to illustrate what the code is doing.
In addition, the code underwent a general cleanup, comments added added, typos were corrected.