This repository was archived by the owner on Jul 20, 2020. It is now read-only.
Conversation
casprice
added
Issue: Feature
Collaborator
Author
|
I know I have extra newlines, I'll get rid of them in the next commit. |
eminguyen
suggested changes
Aug 11, 2019
eminguyen
left a comment
eminguyen
left a comment
Member
There was a problem hiding this comment.
There's also an additional problem that you need http:// and https:// in order to click on the link. If a user puts in an address like google.com, the list doesn't route them to google.com but instead to acmurl.com/google.com. I can look into seeing if there's an alternative way of posting with the form for you
eminguyen
added
PR: Reviewed w/ Comments
Collaborator
Author
|
Yeah that's what I meant by "Still need to add protocol to URLs when redirecting" lol I held off on doing this part because I didn't know how to integrate the Redirect page into the redirection process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes URLs pretty on display. Still need to add protocol to URLs when redirecting.