Implement titles page to view added/deleted tititles on a specific date#6
Draft
acollierr17 wants to merge 23 commits into
Draft
Implement titles page to view added/deleted tititles on a specific date#6acollierr17 wants to merge 23 commits into
acollierr17 wants to merge 23 commits into
Conversation
- add components config file - add card component - update tailwind config
these image paths are relevant to netflix title posters
- add route for getting title information - add route for getting daily titles
it's possible we may need to refactor this in this pr because of the add titles function. will test more BREAKING CHANGE: may break add-new-titles-route
add functionality to view titles added/deleted on a specific date via the path params still a WIP
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
this possibily fixes the 404 issue we're getting running on vercel with dynamic routes
this is in the case we're the main image cannot load for any reason currently, doing it based on error, but hopefully can find a faster solution for one of instances
see if this will resolve the 404 issue. we do want non valid routes not generated or return in generateStaticParams to still 404
this fixes 404 on vercel routes where we have async/await in use
Owner
Author
|
Resolved a Vercel issue with dynamic routes returning Now I need to return a 404 if the |
- remove redundant date param check
return 404 if the date does not exist
Owner
Author
|
Since we're historically allowing titles on previous dates to be displayed, we should implement the ability to request data for individual titles if it's not in the database already. We can clearly resolve this on a per-request basis. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
A WIP, but this PR currently allows viewing what titles have been added/removed on a particular date. If it's an added piece of content, a link to the title on Netflix is also provided.
Currently, we have the title poster, title, and synopsis display. Then there's a page that lists a grid of all available dates. Clicking on a date will display the above content on its respective page.
Currently, these routes are statically generated at build time. We'll likely need to account for future builds and renders.
Fixes #3
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: