Feature/astrometry for testing by AmberLee2427 · Pull Request #1 · acrisp3/gulls

AmberLee2427 · 2025-12-26T11:59:12Z

See docuentation/source/astrometry.rst for details on what was added and how to run it.

I don't think this works with multi-lenses and multi-sources turned on at the same time.

I haven't run a smoke test but I'm falling asleep, so it will have to wait until tomorrow. The math looks correct to read; the centroids are blended and the noise follows Gould & Yee (2014). The syntax might be cooked, but that should be obvious because something won't run properly.

If you run a quick set, we can look closer for any tomfoolery. I'll run a very quick smoke test tomorrow.

Let me know if you have merge dramas with your local branch.

Pull request overview

This PR implements basic astrometry functionality for the gulls microlensing simulator. The implementation adds the ability to compute and output centroid positions of lensed sources in the lens frame, including proper error modeling based on photometric precision and seeing conditions. The feature enables astrometric simulations using the VBM (Variable Brightness Method) low-level functions with noise approximations from Gould & Yee (2014).

Key changes:

Added two new configuration parameters (ASTROMETRY_ON and ASTROMETRIC_SYS_FLOOR) to control astrometry calculations
Renamed Asrc1/Asrc2 variables to musrc1/musrc2 for consistency with magnification nomenclature
Implemented centroid calculation for single and binary source configurations with flux-weighted blending

Show a summary per file

File	Description
src/structures.h	Added astrometry control parameters to filekeywords struct; renamed source magnification vectors from Asrc to musrc
src/readParamfile.cpp	Added parsing for new astrometry configuration parameters (ASTROMETRY_ON, ASTROMETRIC_SYS_FLOOR)
src/timeSequencer.cpp	Updated memory allocation to use renamed musrc1/musrc2 vectors
src/pllxLightcurveGeneratorMultiple.cpp	Enabled VBM astrometry output; stored centroid positions during lightcurve generation; fixed sprintf to snprintf
src/pllxLightcurveGenerator.cpp	Enabled VBM astrometry output; implemented flux-weighted centroid blending for binary sources; stored positions during lightcurve generation
src/photometry.cpp	Implemented Gould & Yee (2014) astrometric error model; added flux-weighted blending with lens/background stars; applied Gaussian noise to centroids
src/outputLightcurve.cpp	Updated output to use renamed musrc1/musrc2 magnification values
documentation/source/astrometry.rst	New comprehensive documentation describing astrometry parameters, coordinate systems, noise model, and affected files
documentation/gulls_documentation.md	Moved vestigial user documentation for gulls simulator installation and usage into `documentation/`
README.md	Added brief description of new astrometry feature

…e flux

- Implemented astrometric error calculations based on photometric precision in `photometry.cpp`. - Updated `lightcurveGenerator.cpp` and `pllxLightcurveGeneratorMultiple.cpp` to handle centroid information for multiple sources. - Introduced new parameters for astrometry in `readParamfile.cpp` and `structures.h` to control astrometric features. - Added documentation for new astrometric functionalities and parameter configurations.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Co-authored-by: AmberLee2427 <26697369+AmberLee2427@users.noreply.github.com>

Guard against division by zero in astrometry calculations

…flux ratio calculation

Co-authored-by: AmberLee2427 <26697369+AmberLee2427@users.noreply.github.com>

AmberLee2427 · 2025-12-27T11:33:04Z

It's tomorrow and I did in fact drop a bracket in photometry.cpp. CI runs without anything suspicious in the logs now, but I didn't tell it to upload artifacts on a success. So I still need to do a sanity-check run and peruse the outputs.

Add v2.1.0 release documentation for astrometry feature

…tion build process

…ml for reproducible CI builds; add .gitkeep to documentation static directory.

…ersion 7

AmberLee2427 · 2025-12-27T13:01:03Z

lightcurves look normal without astrometry on

- Extract gulls version from executable output - v2.1.0 validates minimal lens-frame columns (x_centroid, y_centroid, etc.) - v2.2.0+ validates full sky-frame columns (true_N_centroid_mas, etc.) - Skip astrometry plotting for v2.1.0 (lens-frame only) Co-authored-by: AmberLee2427 <26697369+AmberLee2427@users.noreply.github.com>

Co-authored-by: AmberLee2427 <26697369+AmberLee2427@users.noreply.github.com>

Make smoke test astrometry validation version-aware for v2.1.0 vs v2.2.0+

AmberLee2427 · 2025-12-27T14:10:20Z

bugger. exited with -11. I feel like I've had this error before but I don't know what it means. This might take me a while to fix

…e output

AmberLee2427 · 2025-12-27T14:31:19Z

I think it's PSF dramas. It might work for your run set-up.

…culation Co-authored-by: AmberLee2427 <26697369+AmberLee2427@users.noreply.github.com>

…ed; normalize base paths in parameter file reading

Fix segfault from incorrect loop bound in photometry companion flux calculation

AmberLee2427 · 2025-12-30T08:45:02Z

It was a bad loop. Just me miss-understanding parameters in Event.

I merged with your dev and my CI was not happy. I'm just getting them to play nice now.

Co-authored-by: AmberLee2427 <26697369+AmberLee2427@users.noreply.github.com>

AmberLee2427 · 2025-12-30T09:07:02Z

Missing bracket again. I hate C.

AmberLee2427 · 2025-12-30T09:25:39Z

Tentatively, I think this is good now. It's going to need a more complete sample and a sanity check from Matt.

Smoke Test Results

This release was validated with automated smoke tests. The plots below show sample lightcurves generated by the different Gulls executables:

smoke_croin_0_0_0.all_astrometry_plot.png

smoke_croin_0_0_0.all_plot.png

smoke_croin_binary_0_0_0.det_astrometry_plot.png

smoke_croin_binary_0_0_0.det_plot.png

smoke_fish_0_0_0.all_astrometry_plot.png

smoke_fish_0_0_0.all_plot.png

smoke_fish_binary_0_0_0.det_astrometry_plot.png

smoke_fish_binary_0_0_0.det_plot.png

smoke_std_0_0_0.all_astrometry_plot.png

smoke_std_0_0_0.all_plot.png

smoke_std_binary_0_0_0.det_astrometry_plot.png

smoke_std_binary_0_0_0.det_plot.png

AmberLee2427 added 2 commits November 10, 2025 09:50

rename Asrc* to musrc* to distinguish it from A meaning gulls relativ…

b2c0ba9

…e flux

AmberLee2427 marked this pull request as draft December 26, 2025 12:07

AmberLee2427 marked this pull request as ready for review December 26, 2025 12:08

AmberLee2427 and others added 22 commits December 27, 2025 04:57

Update documentation/source/astrometry.rst

1016e85

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/photometry.cpp

5b245c5

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/pllxLightcurveGeneratorMultiple.cpp

beaba00

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/readParamfile.cpp

255abd7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/pllxLightcurveGeneratorMultiple.cpp

403e855

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Initial plan

7cea02f

Update src/pllxLightcurveGenerator.cpp

f5241b8

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update README.md

69e141f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/photometry.cpp

ef2823e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/pllxLightcurveGeneratorMultiple.cpp

e719719

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update documentation/source/astrometry.rst

c140da1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Add thE validation check to prevent division by zero in astrometry

ca5d23a

Co-authored-by: AmberLee2427 <26697369+AmberLee2427@users.noreply.github.com>

Fix typo: 'abient' -> 'ambient'

c8b34cf

Co-authored-by: AmberLee2427 <26697369+AmberLee2427@users.noreply.github.com>

Complete thE validation check implementation

99005fe

Co-authored-by: AmberLee2427 <26697369+AmberLee2427@users.noreply.github.com>

Remove CodeQL artifact and add to .gitignore

41c9420

Co-authored-by: AmberLee2427 <26697369+AmberLee2427@users.noreply.github.com>

Merge branch 'feature/astrometry-for-testing' into copilot/sub-pr-5

2795513

Merge pull request #6 from AmberLee2427/copilot/sub-pr-5

64789a6

Guard against division by zero in astrometry calculations

Enhance photometry function to handle multiple companion sources for …

668753e

…flux ratio calculation

tidying indentation to search for missing closing bracket

6e344c9

Update version to 2.1.0 and add comprehensive release notes

466a698

Initial plan

a77f9af

Add version 2.1.0 release notes and changelog entry

efcfcc0

Co-authored-by: AmberLee2427 <26697369+AmberLee2427@users.noreply.github.com>

AmberLee2427 added 3 commits December 27, 2025 06:36

Merge pull request #8 from AmberLee2427/copilot/sub-pr-5-another-one

f4dffbe

Add v2.1.0 release documentation for astrometry feature

Release version 2.1.0

c56736c

Reorganize workflow steps: move documentation build and cleanup outputs

701577f

AmberLee2427 added 7 commits December 27, 2025 06:59

Refactor release workflow: add cleanup step and build documentation

12721c5

Refactor release workflow: enhance cleanup step and improve documenta…

5ca07b7

…tion build process

Update Python version requirement to 3.11 in environment.yml

d4d9094

Add astrometry section to documentation table of contents

d9e78f8

Pin Python version to 3.12 and Sphinx version to 6.2 in environment.y…

764b5bb

…ml for reproducible CI builds; add .gitkeep to documentation static directory.

Update CHANGELOG.md: pin Sphinx version due to incompatibility with v…

fa85e6f

…ersion 7

Add astrometry parameters to smoke test configuration files

d3707f1

Copilot AI and others added 4 commits December 27, 2025 13:11

Initial plan

87ea327

Add debug output for detected gulls version

396930a

Co-authored-by: AmberLee2427 <26697369+AmberLee2427@users.noreply.github.com>

Merge pull request #9 from AmberLee2427/copilot/sub-pr-5-another-one

79bd66d

Make smoke test astrometry validation version-aware for v2.1.0 vs v2.2.0+

Add minimal astrometry plotting function and integrate into lightcurv…

10ffeeb

…e output

Copilot AI and others added 5 commits December 30, 2025 08:09

Initial plan

72c6364

Fix segfault: correct loop iteration in photometry companion flux cal…

4edfb00

…culation Co-authored-by: AmberLee2427 <26697369+AmberLee2427@users.noreply.github.com>

Fix PSF initialization check to prevent adding stars when uninitializ…

0ac211b

…ed; normalize base paths in parameter file reading

Merge pull request #10 from AmberLee2427/copilot/sub-pr-5-yet-again

170971f

Fix segfault from incorrect loop bound in photometry companion flux calculation

Merge branch 'dev' into feature/astrometry-for-testing

1e18fac

Copilot AI and others added 2 commits December 30, 2025 08:54

Initial plan

6a76236

Fix merge conflict: add missing closing brace in readParamfile.cpp

cee935a

Co-authored-by: AmberLee2427 <26697369+AmberLee2427@users.noreply.github.com>

Fix merge conflict: restore missing closing brace in readParamfile.cpp

d1446a0

Navigation Menu

Feature/astrometry for testing - #1

Feature/astrometry for testing#1
AmberLee2427 wants to merge 47 commits into
acrisp3:devfrom
AmberLee2427:feature/astrometry-for-testing

AmberLee2427 commented Dec 26, 2025 •

edited

Loading

Uh oh!

AmberLee2427 commented Dec 27, 2025

Uh oh!

AmberLee2427 commented Dec 27, 2025

Uh oh!

AmberLee2427 commented Dec 27, 2025

Uh oh!

AmberLee2427 commented Dec 27, 2025

Uh oh!

AmberLee2427 commented Dec 30, 2025 •

edited

Loading

Uh oh!

AmberLee2427 commented Dec 30, 2025

Uh oh!

AmberLee2427 commented Dec 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

AmberLee2427 commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request overview

Uh oh!

AmberLee2427 commented Dec 27, 2025

Uh oh!

AmberLee2427 commented Dec 27, 2025

Uh oh!

AmberLee2427 commented Dec 27, 2025

Uh oh!

AmberLee2427 commented Dec 27, 2025

Uh oh!

AmberLee2427 commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AmberLee2427 commented Dec 30, 2025

Uh oh!

AmberLee2427 commented Dec 30, 2025

Smoke Test Results

smoke_croin_0_0_0.all_astrometry_plot.png

smoke_croin_0_0_0.all_plot.png

smoke_croin_binary_0_0_0.det_astrometry_plot.png

smoke_croin_binary_0_0_0.det_plot.png

smoke_fish_0_0_0.all_astrometry_plot.png

smoke_fish_0_0_0.all_plot.png

smoke_fish_binary_0_0_0.det_astrometry_plot.png

smoke_fish_binary_0_0_0.det_plot.png

smoke_std_0_0_0.all_astrometry_plot.png

smoke_std_0_0_0.all_plot.png

smoke_std_binary_0_0_0.det_astrometry_plot.png

smoke_std_binary_0_0_0.det_plot.png

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AmberLee2427 commented Dec 26, 2025 •

edited

Loading

AmberLee2427 commented Dec 30, 2025 •

edited

Loading