Keep V3 token caches local to each client - #27
Draft
SproutSeeds wants to merge 1 commit into
Draft
SproutSeeds wants to merge 1 commit into
SproutSeeds wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved the V3 token cache onto each client while preserving reuse by API scope. With the current module cache, two clients using different credentials can send the first client's token for the same scope. The regression test reproduces that behavior and passes with the instance cache.
Fourteen offline checks pass, covering alternating clients, scope routing across all eight V3 entry points, pagination ordering, independent invalidation, and the original 404 control. Original lint checks pass. Linux fork CI passes all 14 offline checks, original lint, and builds on Python 3.11 and 3.12: https://github.com/SproutSeeds/actiapi/actions/runs/34814951073. The workflow checks out this exact contribution commit. The 13 existing live study tests remain unrun. This draft establishes the client behavior using synthetic credentials and mocked responses.
I would like to complete live API verification for this contribution. Could you provide access to a test study containing synthetic data, or run the existing integration tests against this branch? You can reach me at cody@frg.earth to coordinate account setup and secure credential delivery.
I also sent a provisioning inquiry to support@ametris.com referencing this PR. The upstream Actions run is waiting for maintainer approval; the fork verification above has completed.
Cody