Activate uploaded Worker versions - #13
Merged
Merged
Conversation
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploy runs uploaded new Worker versions but printed “No targets deployed,” leaving production traffic on an older version because the custom domain is managed outside Wrangler. This made successful GitHub Actions runs appear deployed while none of the recent automerge fixes were live.
Tag each uploaded version with the source commit, then explicitly deploy that tag at 100% traffic. This preserves Terraform ownership of the custom domain and makes each CI deployment active.
Validated with npm test, npm run check, npm run format:check, and npm run build. Local actionlint is unavailable; GitHub Actions will validate workflow execution.