Fix repeated automerge grace periods - #8
Merged
Merged
Conversation
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents eligible pull requests from hanging when GitHub has not exposed their automerge label event yet.
The grace-period calculation previously returned a fresh 10-second delay on every evaluation loop when issue-event history lacked the active label. That loop could outlive Cloudflare's background-processing window, so no merge was attempted unless another webhook retriggered evaluation.
This change records when the evaluation first observes the active label and uses that stable timestamp until GitHub event history becomes available. Label removal, eligibility rechecks, and SHA-pinned merges remain unchanged. It also adds regression coverage for delayed label-event visibility and documents the fallback behavior.
Validated with
npm run check,npm run format:check,npm test(41 tests), andnpm run build.