Wait for GitHub mergeability - #9
Merged
Merged
Conversation
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes batch automerge when an earlier pull request changes the base branch.
PRs
timkpaine/jupyterlab-iframe#207and#209were approved and green, but became behindmainafter#208merged. Their test merge refs were generated only when the App evaluated them. GitHub calculates that mergeability asynchronously and initially returnsmergeable: null; the App immediately attempted the merge and GitHub rejected it.This change polls pull request state once per second until GitHub reports mergeability, with a 10-second cap that leaves room for the existing label grace period inside Cloudflare's background-processing limit. Conflicting pull requests remain open. Check gating, label cancellation, and SHA-pinned merge requests are unchanged.
Validated with
npm run check,npm run format:check,npm test(44 tests), andnpm run build.