-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: add support for mise.toml file #1421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for parsing Node.js versions from mise.toml configuration files, extending the action's capability to read version specifications from mise tool manager configurations.
Key Changes:
- Added TOML parsing functionality to extract Node.js versions from
mise.tomlfiles - Updated documentation to include
mise.tomlas a supported version file format - Added test coverage for the new TOML parsing feature
Reviewed Changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/util.ts | Added TOML parsing logic to extract Node.js version from mise.toml files with support for both string and object formats |
| package.json | Added js-toml dependency for TOML file parsing |
| tests/main.test.ts | Added test case for mise.toml format and reorganized imports |
| README.md | Updated documentation to list mise.toml as a supported version file format |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@aparnajyothi-y can you take a look at this please? Sorry for pinging you btw 🙏🏻 |
|
Any update regarding to this? |
|
+1 on this |
e442ec6 to
3679703
Compare
3679703 to
4bd80ce
Compare
|
Hi team 👋 I hope you're all doing well! I wanted to kindly follow up on this PR that adds support for mise.toml files. It's been open for about two months now and I haven't received any feedback from maintainers yet. The PR: Addresses issue #1304 cc @aparnajyothi-y @mahabaleshwars @priyagupta108 @actions/setup-actions-team Thank you for your time and for maintaining this great action! 🙏 |
Description:
This MR add support for mise.toml file - https://mise.jdx.dev
Related issue:
#1304
Check list: