Feature/6.1/tracing util#10
Open
TravisWhip wants to merge 2 commits into
Open
Conversation
… that automatically close when going out of scope.
|
Hey @TravisWhip, |
Author
|
Hey @obilliard, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a simple utility to create tracing Spans.
Closable spans
These spans are wrapped in a Closable class so they are ended when out of scope. Spans can be easily created to track a method / given scope.
Example usages
I have added a span around the initial load.
This gives us a span with sub-spans:

Automatic closing of Span when out of scope:
Spans can be kept open:
Cleanup still required
The property
TracingUtil.defaultTracingScopeNameis static and set at startup from a Void bean which may not be the cleanest.