Broadcast options - #38
Merged
Merged
Conversation
srosset81
reviewed
Nov 26, 2024
Laurin-W
requested changes
Nov 27, 2024
Laurin-W
left a comment
Laurin-W
left a comment
Contributor
There was a problem hiding this comment.
Really nice feature! :)
Mentions working properly
Style mentions in PostBlock.jsx fix carriage return replacement expression in Note.jsx
Visibility implemented and working
Direct messages
Direct messages : Add backdrop and spinner when submitting PostBlock.jsx : Adjust visibility selecter's design add i18n to MentionsList.jsx add comments to useMentions.js
SlyRock
force-pushed
the
broadcast-options
branch
from
December 2, 2024 09:49
adcd30e to
945f877
Compare
SlyRock
marked this pull request as ready for review
December 2, 2024 09:52
SlyRock
force-pushed
the
broadcast-options
branch
from
December 2, 2024 12:33
da16de9 to
0d8e00c
Compare
srosset81
approved these changes
Dec 2, 2024
srosset81
left a comment
srosset81
left a comment
Contributor
There was a problem hiding this comment.
I read the whole code and it is very clean, thank you !
Just one minor graphical thing: the public (earth) icon is green while the others are black. It would be better to have everything the same color (maybe black). Also there is a blank option that is useless (if you select it, it selects the public broadcast mode).
last cosmetic fix on visibility selector
srosset81
self-requested a review
December 2, 2024 16:25
srosset81
approved these changes
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #5 Mention users
closes #6 Choose message broadcast mode
closes #11 Direct messages