Add custom charge limit submenu with presets#444
Open
GuilhermeBianeck wants to merge 1 commit intoactuallymentor:mainfrom
Open
Add custom charge limit submenu with presets#444GuilhermeBianeck wants to merge 1 commit intoactuallymentor:mainfrom
GuilhermeBianeck wants to merge 1 commit intoactuallymentor:mainfrom
Conversation
This PR introduces the ability for users to select a specific battery charge limit (e.g., 60%, 70%, 90%) directly from the menu bar app. Previously, the app was hardcoded to toggle only at 80%. The new "Set charge limit" submenu allows for granular control while maintaining the existing "Enable/Disable" workflow. + space removals Description Feature Changes: New Submenu: Added a "Set charge limit" menu containing presets: 60%, 70%, 75%, 80%, 90%, and 100%. Dynamic Labels: The main "Enable" button now dynamically reads "Enable battery limit at X%" based on the user's selection. Persistence: The selected charge limit is saved using electron-store and persists across app restarts. Live Updates: Changing the limit while the limiter is active immediately restarts the background maintenance process at the new level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability for users to select a specific battery charge limit (e.g., 60%, 70%, 90%) directly from the menu bar app. Previously, the app was hardcoded to toggle only at 80%. The new "Set charge limit" submenu allows for granular control while maintaining the existing "Enable/Disable" workflow. + space removals Description
Feature Changes:
New Submenu: Added a "Set charge limit" menu containing presets: 60%, 70%, 75%, 80%, 90%, and 100%.
Dynamic Labels: The main "Enable" button now dynamically reads "Enable battery limit at X%" based on the user's selection.
Persistence: The selected charge limit is saved using electron-store and persists across app restarts.
Live Updates: Changing the limit while the limiter is active immediately restarts the background maintenance process at the new level.