Enforce size limit in publish()#258
Merged
Merged
Conversation
adafruit-adabot
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 20, 2026
Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 8.1.0 from 8.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#258 from FoamyGuy/msg_size_limit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #257
Adds a check and raise against the user configurable
mqtt_msgproperty that holds a message size limit.This change will help the AdafruitIO library have a better error behavior when attempting to publish a message that is too large.
I also think that
mqtt_msgproperty name is kind of confusing for the size, but I have left it alone for now since changing would break the API. Though the properties value seemed to have no effect before this change anyhow.