correct calculation in greaseunpack for 2 byte value#54
Open
erpebe wants to merge 1 commit intoadafruit:mainfrom
Open
correct calculation in greaseunpack for 2 byte value#54erpebe wants to merge 1 commit intoadafruit:mainfrom
erpebe wants to merge 1 commit intoadafruit:mainfrom
Conversation
The calculation in greaseunpack for a 2 byte code (values between 250..1524) was wrong
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File greasepack.h
The calculation in greaseunpack for a 2 byte code (values between 250..1524) was wrong
Example
encoding the value 1000 in greaspack()
unsigned high = (value - 250) / 255; -> (1000 - 250) / 255 => 2
*buf++ = 250 + high; -> 250 + 2 => 252
*buf++ = 1 + (value - 250) % 255; -> 1 + (1000 - 250) % 255 => 241
decoding 252, 241
old: (252 - 250 + 1) * 250 + 241 => 991 wrong
new: 250 + (252 -250) * 255 + 241 -1 => 1000 correct