Wippersnapper preprocessor script for printing the library versions to boot outtxt#196
Open
tyeth wants to merge 9 commits intoadafruit:ci-wippersnapperfrom
Conversation
brentru
requested changes
Oct 11, 2024
This reverts commit 8d6b9d9.
Member
Author
|
@brentru this is ready for re-review. Hopefully this is resolved satisfactorily, I've acted on the great suggestions and added some context for the os.system change (use "show resolved") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@brentru this is tied in with adafruit/Adafruit_Wippersnapper_Arduino#607
It adds a new flag to allow specifying the location of the header file to be generated/replaced
--include_print_dependencies_headeralthough now I've settled on not being able to modify the build flags I could probably pick a better name as it no longer adds an extra include to the build flags.